-
Notifications
You must be signed in to change notification settings - Fork 29
Private channels #706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Private channels #706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lilla28
reviewed
Jul 9, 2024
...sktopAgent/src/MorganStanley.ComposeUI.DesktopAgent/Contracts/CreatePrivateChannelRequest.cs
Outdated
Show resolved
Hide resolved
lilla28
reviewed
Jul 15, 2024
...anley.ComposeUI.DesktopAgent/Infrastructure/Internal/Fdc3DesktopAgentMessageRouterService.cs
Show resolved
Hide resolved
8503932
to
e33e372
Compare
d798821
to
a26bcba
Compare
lilla28
previously approved these changes
Aug 5, 2024
src/fdc3/dotnet/DesktopAgent/src/MorganStanley.ComposeUI.DesktopAgent/Fdc3DesktopAgent.cs
Outdated
Show resolved
Hide resolved
src/fdc3/dotnet/DesktopAgent/src/MorganStanley.ComposeUI.DesktopAgent/Fdc3DesktopAgent.cs
Outdated
Show resolved
Hide resolved
src/fdc3/js/composeui-fdc3/src/infrastructure/ComposeUIPrivateChannel.ts
Show resolved
Hide resolved
21ad537
to
b46cd6a
Compare
…ce JSON configuration
Updated fdc3 tests remove test-only path from contextlistener
b46cd6a
to
08d1829
Compare
lilla28
approved these changes
Aug 13, 2024
ztanczos
reviewed
Aug 21, 2024
src/messaging/dotnet/src/Client/DependencyInjection/ServiceCollectionExtensions.cs
Show resolved
Hide resolved
ztanczos
reviewed
Aug 21, 2024
ztanczos
reviewed
Aug 21, 2024
...opAgent/src/MorganStanley.ComposeUI.DesktopAgent/MorganStanley.ComposeUI.DesktopAgent.csproj
Show resolved
Hide resolved
ztanczos
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To try Private Channels, use the example "fdc3-pricing-and-chat". It has a readme to see how to use it.
There are some minor fixes in separate commits that were too small to separate and in cases blocking for this feature.