Skip to content

Conversation

ZKRobi
Copy link
Member

@ZKRobi ZKRobi commented Jul 2, 2024

To try Private Channels, use the example "fdc3-pricing-and-chat". It has a readme to see how to use it.
There are some minor fixes in separate commits that were too small to separate and in cases blocking for this feature.

@ZKRobi ZKRobi force-pushed the feature/private-channels branch 2 times, most recently from 8503932 to e33e372 Compare July 19, 2024 13:02
@ZKRobi ZKRobi force-pushed the feature/private-channels branch 3 times, most recently from d798821 to a26bcba Compare August 5, 2024 15:44
@ZKRobi ZKRobi marked this pull request as ready for review August 5, 2024 15:44
@ZKRobi ZKRobi requested a review from a team as a code owner August 5, 2024 15:44
lilla28
lilla28 previously approved these changes Aug 5, 2024
@ZKRobi ZKRobi force-pushed the feature/private-channels branch 3 times, most recently from 21ad537 to b46cd6a Compare August 12, 2024 10:40
@ZKRobi ZKRobi force-pushed the feature/private-channels branch from b46cd6a to 08d1829 Compare August 12, 2024 11:32
Copy link

codecov bot commented Aug 12, 2024

Codecov Report

Attention: Patch coverage is 63.66864% with 307 lines in your changes missing coverage. Please review.

Project coverage is 67.66%. Comparing base (324b85c) to head (08d1829).
Report is 24 commits behind head on main.

Files Patch % Lines
...fdc3/src/infrastructure/ComposeUIPrivateChannel.ts 40.79% 119 Missing ⚠️
.../src/infrastructure/MessageRouterChannelFactory.ts 64.58% 34 Missing ⚠️
...ture/PrivateChannelContextListenerEventListener.ts 33.33% 30 Missing ⚠️
...structure/PrivateChannelDisconnectEventListener.ts 33.33% 30 Missing ⚠️
...c3/src/infrastructure/ComposeUIIntentResolution.ts 24.00% 19 Missing ⚠️
...ucture/messages/Fdc3PrivateChannelInternalEvent.ts 50.00% 13 Missing ⚠️
...topAgent/Contracts/CreatePrivateChannelResponse.cs 0.00% 10 Missing ⚠️
...dc3/js/composeui-fdc3/src/ComposeUIDesktopAgent.ts 91.75% 8 Missing ⚠️
...dc3/src/infrastructure/ComposeUIContextListener.ts 74.19% 8 Missing ⚠️
...Stanley.ComposeUI.DesktopAgent/Channels/Channel.cs 89.70% 4 Missing and 3 partials ⚠️
... and 7 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #706      +/-   ##
==========================================
- Coverage   69.26%   67.66%   -1.61%     
==========================================
  Files         250      261      +11     
  Lines        7608     7997     +389     
  Branches      912      847      -65     
==========================================
+ Hits         5270     5411     +141     
- Misses       2149     2400     +251     
+ Partials      189      186       -3     
Files Coverage Δ
...ley.ComposeUI.DesktopAgent/Channels/UserChannel.cs 100.00% <100.00%> (ø)
...re/Internal/ResolverUIMessageRouterCommunicator.cs 100.00% <ø> (ø)
...poseui-fdc3/src/infrastructure/ComposeUIChannel.ts 96.38% <100.00%> (-3.62%) ⬇️
...ucture/messages/Fdc3CreatePrivateChannelRequest.ts 100.00% <100.00%> (ø)
...et/src/Abstractions/MessageBufferJsonExtensions.cs 100.00% <100.00%> (ø)
...DependencyInjection/ServiceCollectionExtensions.cs 100.00% <100.00%> (ø)
...net/src/Core/MessageBufferFactoryJsonExtensions.cs 100.00% <ø> (ø)
.../dotnet/Shell/Fdc3/ResolverUI/ResolverUIService.cs 65.38% <ø> (ø)
...omposeui-fdc3/src/infrastructure/ComposeUITopic.ts 91.00% <94.44%> (+1.30%) ⬆️
....ComposeUI.DesktopAgent/Channels/PrivateChannel.cs 0.00% <0.00%> (ø)
... and 15 more

... and 4 files with indirect coverage changes

@ZKRobi ZKRobi merged commit 7a5c0e9 into morganstanley:main Aug 22, 2024
@ZKRobi ZKRobi deleted the feature/private-channels branch August 22, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants