Skip to content

Conversation

agyen
Copy link
Contributor

@agyen agyen commented Feb 5, 2024

  • A hack around modulesPrototype to use grpc web to enable backend-frontend communication.
  • Frontend connects and presents processes data.

@agyen agyen requested a review from a team as a code owner February 5, 2024 13:10
@agyen agyen force-pushed the Grpc-backend branch 3 times, most recently from 8750d08 to 2a820ea Compare February 7, 2024 16:33
Copy link

codecov bot commented Feb 7, 2024

Codecov Report

Attention: Patch coverage is 42.85714% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 74.38%. Comparing base (36bb2b2) to head (d0c8c56).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #459      +/-   ##
==========================================
- Coverage   74.38%   74.38%   -0.01%     
==========================================
  Files         238      238              
  Lines        7351     7358       +7     
  Branches      871      812      -59     
==========================================
+ Hits         5468     5473       +5     
- Misses       1688     1695       +7     
+ Partials      195      190       -5     
Files Coverage Δ
...cture/Grpc/ProcessExplorerMessageHandlerService.cs 96.42% <ø> (ø)
...r/Abstractions/ProcessExplorerBuilderExtensions.cs 61.53% <42.85%> (-21.80%) ⬇️

... and 5 files with indirect coverage changes

@kruplm kruplm changed the title Backend to support Grpc web and frontend to read data from the backend feat(ProcessExplorer/js): Reading Data with gRPC-Web from ModulesPrototype Test Backend Feb 19, 2024
@agyen agyen force-pushed the Grpc-backend branch 2 times, most recently from 3b1b5b3 to 172b930 Compare April 3, 2024 15:14
kruplm
kruplm previously approved these changes Apr 8, 2024
@ZKRobi ZKRobi self-requested a review April 8, 2024 14:22
Copy link
Member

@ZKRobi ZKRobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the regression noted by Lilla before merging

@kruplm kruplm changed the base branch from main to feat-process-explorer-grpc April 9, 2024 10:26
@kruplm kruplm changed the base branch from feat-process-explorer-grpc to main April 10, 2024 08:53
@kruplm kruplm dismissed their stale review April 10, 2024 08:53

The base branch was changed.

@ZKRobi ZKRobi self-requested a review April 10, 2024 11:33
Copy link
Member

@ZKRobi ZKRobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with merging if Lilla approves the fix to the regression she noticed.

ZKRobi
ZKRobi previously approved these changes Apr 10, 2024
kruplm
kruplm previously approved these changes Apr 10, 2024
@agyen agyen dismissed stale reviews from kruplm and ZKRobi via 3dd1d2c April 15, 2024 08:44
@lilla28
Copy link
Contributor

lilla28 commented Apr 15, 2024

Please squash your commits! :)

@kruplm kruplm merged commit 71a5257 into morganstanley:main Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants