-
Notifications
You must be signed in to change notification settings - Fork 29
feat(ProcessExplorer/js): Reading Data with gRPC-Web from ModulesPrototype Test Backend #459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
8750d08
to
2a820ea
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #459 +/- ##
==========================================
- Coverage 74.38% 74.38% -0.01%
==========================================
Files 238 238
Lines 7351 7358 +7
Branches 871 812 -59
==========================================
+ Hits 5468 5473 +5
- Misses 1688 1695 +7
+ Partials 195 190 -5
|
...ley.ComposeUI.ProcessExplorer.Server/Server/Abstractions/ProcessExplorerBuilderExtensions.cs
Show resolved
Hide resolved
...UI.ProcessExplorer.Server/Server/Infrastructure/Grpc/ProcessExplorerMessageHandlerService.cs
Show resolved
Hide resolved
prototypes/multi-module-prototype/examples/multi-module-example/ModulesPrototype/Program.cs
Outdated
Show resolved
Hide resolved
...process-explorer/oss-frontend/src/app/generated-protos-files/ProcessExplorerMessages_pb.d.ts
Show resolved
Hide resolved
prototypes/multi-module-prototype/examples/multi-module-example/ModulesPrototype/Program.cs
Show resolved
Hide resolved
prototypes/multi-module-prototype/examples/multi-module-example/ModulesPrototype/Program.cs
Show resolved
Hide resolved
prototypes/process-explorer/oss-frontend/src/app/components/processes/processes.component.ts
Outdated
Show resolved
Hide resolved
3b1b5b3
to
172b930
Compare
prototypes/process-explorer/oss-frontend/src/app/components/processes/processes.component.ts
Outdated
Show resolved
Hide resolved
prototypes/process-explorer/oss-frontend/src/app/components/processes/processes.component.ts
Outdated
Show resolved
Hide resolved
...otypes/process-explorer/oss-frontend/src/app/services/processes-service/processes.service.ts
Outdated
Show resolved
Hide resolved
prototypes/process-explorer/oss-frontend/src/app/components/processes/processes.component.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address the regression noted by Lilla before merging
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with merging if Lilla approves the fix to the regression she noticed.
prototypes/process-explorer/oss-frontend/src/app/components/processes/processes.component.ts
Show resolved
Hide resolved
...otypes/process-explorer/oss-frontend/src/app/services/processes-service/processes.service.ts
Outdated
Show resolved
Hide resolved
...otypes/process-explorer/oss-frontend/src/app/services/processes-service/processes.service.ts
Outdated
Show resolved
Hide resolved
Please squash your commits! :) |
Uh oh!
There was an error while loading. Please reload this page.