-
Notifications
You must be signed in to change notification settings - Fork 29
Fdc3 - Enable Fdc3 as an optional feature #347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #347 +/- ##
==========================================
+ Coverage 74.58% 77.29% +2.70%
==========================================
Files 155 156 +1
Lines 5474 5302 -172
Branches 233 233
==========================================
+ Hits 4083 4098 +15
+ Misses 1390 1203 -187
Partials 1 1
|
0e12856
to
c079d51
Compare
src/fdc3/dotnet/DesktopAgent/src/DesktopAgent/Utilities/ResourceReader.cs
Show resolved
Hide resolved
src/fdc3/dotnet/DesktopAgent/src/DesktopAgent/Common/PreloadFdc3Names.cs
Outdated
Show resolved
Hide resolved
src/fdc3/dotnet/DesktopAgent/src/DesktopAgent/DesktopAgent.csproj
Outdated
Show resolved
Hide resolved
eec754c
to
598968e
Compare
...fdc3/dotnet/DesktopAgent/src/DesktopAgent/DependencyInjection/ServiceCollectionExtensions.cs
Outdated
Show resolved
Hide resolved
src/fdc3/dotnet/DesktopAgent/src/DesktopAgent/DependencyInjection/Fdc3DesktopAgentBuilder.cs
Outdated
Show resolved
Hide resolved
src/fdc3/dotnet/DesktopAgent/src/DesktopAgent/Fdc3DesktopAgent.cs
Outdated
Show resolved
Hide resolved
ztanczos
reviewed
Sep 6, 2023
src/fdc3/dotnet/DesktopAgent/src/DesktopAgent/DependencyInjection/Fdc3DesktopAgentBuilder.cs
Outdated
Show resolved
Hide resolved
...fdc3/dotnet/DesktopAgent/src/DesktopAgent/DependencyInjection/ServiceCollectionExtensions.cs
Outdated
Show resolved
Hide resolved
0aa0317
to
a6d160b
Compare
540e07b
to
4550c10
Compare
src/fdc3/dotnet/DesktopAgent/src/DesktopAgent/DependencyInjection/Fdc3DesktopAgentBuilder.cs
Outdated
Show resolved
Hide resolved
src/fdc3/dotnet/DesktopAgent/src/DesktopAgent/Fdc3DesktopAgent.cs
Outdated
Show resolved
Hide resolved
7d333dd
to
771495b
Compare
BalassaMarton
previously approved these changes
Sep 11, 2023
94b3e49
to
1b528ec
Compare
ZKRobi
approved these changes
Sep 12, 2023
kruplm
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Directory.Build.props
filescomposeui-fdc3
js implementation underfdc3/js
folderPreloadFdc3
toResourceNames
MessagingRouter.Client
to the solution for building the projectShell
andShell.Tests
projects,Fdc3Options
to check if it is enabled fromappsettings.json
Fdc3DesktopAgentConfig
toFdc3DesktopAgentBuilder
ServiceCollectionExtensions
inFdc3DesktopAgent
ServiceCollection
extension method forDesktopAgent
to check theFdc3Options
and injectDesktopAgent
if that is enabled from configResourceReader
that we should move this utility to a new project later undersrc/shared/dotnet
DesktopAgent.Tests
'sDesktopAgent
setupWithUserChannel
fromDesktopAgent
'sFdc3DesktopAgentBuilder
BuilderActions
property fromFdc3Options