Skip to content

Conversation

kruplm
Copy link
Contributor

@kruplm kruplm commented Feb 28, 2023

  • For better testability the cli code has been refactored
  • Rollup has been removed because it caused issues with the shebang
  • Catching the exit code of the Shell

@kruplm kruplm force-pushed the node-launcher-tests branch 2 times, most recently from 41661b0 to c1090fc Compare February 28, 2023 13:19
@kruplm kruplm force-pushed the node-launcher-tests branch from c1090fc to f34a472 Compare February 28, 2023 13:44
@kruplm kruplm marked this pull request as ready for review February 28, 2023 15:16
@kruplm kruplm requested a review from a team February 28, 2023 15:16
@kruplm kruplm changed the title Tests for compose-node-launcher [WIP] Tests for compose-node-launcher Feb 28, 2023
@kruplm kruplm changed the title Tests for compose-node-launcher Tests for composeui-node-launcher Feb 28, 2023
@BalassaMarton BalassaMarton self-requested a review March 2, 2023 16:03
@kruplm kruplm merged commit ba0bdf0 into morganstanley:main Mar 2, 2023
@kruplm kruplm added this to the Compose as a web container milestone Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants