Skip to content

Conversation

ZKRobi
Copy link
Member

@ZKRobi ZKRobi commented Jul 21, 2025

Merged MessagingAdapter.Abstractions and Messaging.Abstractions
Adjusted Messaging interfaces to better suit the needs of ComposeUI (and specifically FDC3)

@ZKRobi ZKRobi changed the title Re-defining messaging interfaces Merging and adjusting messaging interfaces Jul 21, 2025
@ZKRobi ZKRobi force-pushed the messaging branch 4 times, most recently from bc53488 to f002868 Compare July 22, 2025 10:53
@ZKRobi ZKRobi marked this pull request as ready for review July 22, 2025 11:39
@ZKRobi ZKRobi requested a review from a team as a code owner July 22, 2025 11:39
lilla28
lilla28 previously approved these changes Jul 24, 2025
Copy link
Contributor

@lilla28 lilla28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@ZKRobi ZKRobi force-pushed the messaging branch 6 times, most recently from 6ce7644 to 82c20b0 Compare July 25, 2025 09:33
Copy link

codecov bot commented Jul 25, 2025

Codecov Report

❌ Patch coverage is 53.93258% with 123 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.5%. Comparing base (ae83a75) to head (b4ac5a5).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...Stanley.ComposeUI.DesktopAgent/Fdc3DesktopAgent.cs 5.0% 19 Missing ⚠️
.../src/infrastructure/MessageRouterChannelFactory.ts 22.7% 17 Missing ⚠️
...cture/Internal/Fdc3DesktopAgentMessagingService.cs 68.2% 13 Missing ⚠️
src/shell/dotnet/src/Shell/App.xaml.cs 0.0% 11 Missing ⚠️
...net/src/Shell/Fdc3/ResolverUI/ResolverUIService.cs 60.0% 10 Missing ⚠️
...fdc3/src/infrastructure/ComposeUIPrivateChannel.ts 12.5% 7 Missing ⚠️
...src/MessageRouterAdapter/MessageRouterMessaging.cs 81.2% 5 Missing and 1 partial ⚠️
.../src/Abstractions/Exceptions/MessagingException.cs 0.0% 5 Missing ⚠️
...Stanley.ComposeUI.DesktopAgent/Channels/Channel.cs 76.4% 2 Missing and 2 partials ⚠️
....ComposeUI.DesktopAgent/Channels/PrivateChannel.cs 0.0% 4 Missing ⚠️
... and 10 more

❌ Your patch status has failed because the patch coverage (53.9%) is below the target coverage (100.0%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #1053     +/-   ##
=======================================
- Coverage   65.8%   65.5%   -0.3%     
=======================================
  Files        343     338      -5     
  Lines      10061    9982     -79     
  Branches    1213    1212      -1     
=======================================
- Hits        6626    6548     -78     
+ Misses      3167    3165      -2     
- Partials     268     269      +1     
Files with missing lines Coverage Δ
...nley.ComposeUI.DesktopAgent/Channels/AppChannel.cs 50.0% <100.0%> (ø)
...ley.ComposeUI.DesktopAgent/Channels/UserChannel.cs 100.0% <100.0%> (ø)
.../MorganStanley.ComposeUI.DesktopAgent/Fdc3Topic.cs 80.0% <100.0%> (+0.4%) ⬆️
...ctions/Exceptions/DuplicateServiceNameException.cs 0.0% <ø> (ø)
...DependencyInjection/ServiceCollectionExtensions.cs 100.0% <ø> (ø)
...essaging/dotnet/src/Core/Exceptions/ThrowHelper.cs 50.0% <ø> (+8.3%) ⬆️
src/messaging/dotnet/src/Core/InvokeOptions.cs 100.0% <ø> (ø)
src/messaging/dotnet/src/Core/MessageContext.cs 100.0% <ø> (ø)
...c/Core/Protocol/Messages/RegisterServiceRequest.cs 100.0% <ø> (ø)
src/messaging/dotnet/src/Core/PublishOptions.cs 100.0% <ø> (ø)
... and 21 more

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Merged the original IMessageRouter and IMessagingService interfaces
Replaced IMessagingService with IMessaging
Adjusted IMessaging to better suit FDC3
Removed unused MessageRouter interfaces
lilla28
lilla28 previously approved these changes Jul 25, 2025
Copy link
Contributor

@lilla28 lilla28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@kruplm kruplm merged commit 280bf3b into morganstanley:main Jul 28, 2025
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants