Updated readme for directions when supporting Android M or above #119
Conversation
wildseansy
force-pushed
the
android-permissions
branch
3 times, most recently
from
7f5ac46 to
be94eba
Compare
morenoh149
left a comment
morenoh149
left a comment
There was a problem hiding this comment.
Please restore the newlines here, by restoring the carriage return or adding bullet points. And squash commits.
|
|
||
|
|
||
| ## API | ||
| `getAll` (callback) - returns *all* contacts as an array of objects |
There was a problem hiding this comment.
looks like the whitespace removed here removed the newlines? These should each be rendered on their own line.
| ``` | ||
|
|
||
| ## Permissions Methods (optional) | ||
| `checkPermission` (callback) - checks permission to access Contacts. |
There was a problem hiding this comment.
newlines were removed here also
README.md
Outdated
|
|
||
| #### Permissions on Android M and greater | ||
|
|
||
| Because permissions need need to be granted at time of use in Android M, use [`react-native-android-permissions`](https://github.com/lucasferreira/react-native-android-permissions) to request permissions if you support Android M or above. |
There was a problem hiding this comment.
Because permissions need need to be granted -> Because permissions need to be granted
|
could you briefly explain to me now, when would an Android M user ever use the old |
wildseansy
force-pushed
the
android-permissions
branch
from
be94eba to
f79f9f6
Compare
|
@morenoh149 - The old
An alternative approach would be to wrap usage of |
|
@morenoh149 - removed spacing. Ready for review. |
|
@theseansy If i'm reading correctly it looks like that module (https://github.com/lucasferreira/react-native-android-permissions) has been merged into RN proper (facebook/react-native#9292) and the repository for react-native-android-permissions now lists it as a deprecated module! We can now user which means we could update the internal API of this module to use that as well (as you suggested) |
|
@SRandazzo - awesome. Will close. |
3 participants
See #115 for more info. @morenoh149
Closes #115