Fix the import for apps with a base path #3092
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
github-actions bot
pushed a commit
that referenced
this pull request
Dec 2, 2024
(cherry picked from commit 6a2982a)
mattleibow
added a commit
that referenced
this pull request
Dec 2, 2024
(cherry picked from commit 6a2982a) Co-authored-by: Matthew Leibowitz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
The changes in #3064 resolved many issues, but when we tried to account for the fact that the new loading mechanisms used a different path, we forced an absolute path. This does not work when using a custom base path.
This PR uses the recommended way of a relative path as seen in the docs: https://learn.microsoft.com/aspnet/core/blazor/javascript-interoperability/import-export-interop?view=aspnetcore-9.0#razor-class-library-rcl-collocated-js-is-unsupported