CSHARP-4245: Dispose CancellationTokenSource in tests #846
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesKovacs
requested changes
Jul 12, 2022
| var subject = CreateSubject(); | ||
| var service = "_mongodb._tcp.test5.test.build.10gen.cc"; | ||
| var cts = new CancellationTokenSource(); | ||
| using var cts = new CancellationTokenSource(); |
There was a problem hiding this comment.
Since we are updating these lines anyways, let's go with our usual coding standard of not using abbreviations.
cts => cancellationTokenSource
Same elsewhere.
| var cancellationToken = new CancellationTokenSource().Token; | ||
| var task1 = Task.FromResult<object>(null); | ||
| mockStream.Setup(s => s.CopyToAsync(mockDestination.Object, bufferSize, cancellationToken)).Returns(task1); | ||
| mockStream.Setup(s => s.CopyToAsync(mockDestination.Object, bufferSize, default)).Returns(task1); |
There was a problem hiding this comment.
Isn't this changing the meaning of the test? Previously we were asserting that the passed-in CancellationTokenSource was passed correctly. But since CancellationTokenSource is a class default(CancellationTokenSource is simply null. Thus we cannot tell if the CancellationTokenSource is being correctly passed through or if we are simply explicitly passing null through the call chain.
| var result = subject.ExecuteReadOperation(binding, mockOperation.Object, default); | ||
|
|
||
| mockOperation.Verify(m => m.Execute(binding, cancellationToken), Times.Once); | ||
| mockOperation.Verify(m => m.Execute(binding, default), Times.Once); |
There was a problem hiding this comment.
Same concern around the use of default as with the previous file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.