v0.18.4.4 release to-do list

[selsta]

The following pull requests have to be merged, tests have to be done and issues have to be resolved.

• wallet: identify spends in pool when scanning [v0.18] #10153
• Bug: unidentified spend tx in pool on wallet restore #10013
• Fix logging lock behavior [v0.18] #10194
• ledger: throw on secret view key export rejection [v0.18] #10195
• build: prepare v0.18.4.4 #10199
• cryptonote_protocol: accurate next_needed_height when there is an overlap [release]  #10202
• tx pool: only increment m_txpool_weight for newly added pool txs [v0.18] #10204
• Daemon: relay empty fluffy block on found block [v0.18] #10206
• Test a full chain sync
• Tag v0.18.4.4
• Release on website

Please add a comment if I'm missing anything or if there are other suggestions.

[johnalanwoods]

After seeing this post on r/Monero earlier I decided to test myself, and it indeed does seem that Ledger Flex support isn't working, was able to reproduce on Ubuntu and macOS:

https://www.reddit.com/r/Monero/comments/1ozinlp/ledger_flex_and_monero/

Given it was introduced in 18.4.3 might be worth adding to the to-do for 18.4.4

[nahuhh]

18.4.4 is already tagged

iirc, historically all ledgers use the same interface with monero cli/gui. if flex isnt working, then theres probably some incompatibility with flex that requires a special integration

[selsta]

@johnalanwoods did you make sure to correctly open the Ledger monero app? According to this comment, Ledger Flex and monero work as long as you open the app.

monero-project/monero-gui#4438 (comment)

[johnalanwoods]

@selsta - yep indeed, clean machines, no Ledger Live and Flex itself unlocked with Monero app open (latest build), and in fact the Flex had been working for me previously. I think maybe 1.5.0 FW borked it.

Will try to test further.

Are there any debug flags I can use for better logging from the wallet CLI?

[johnalanwoods]

FWIW, the security app and Algorand CLI wallets are working fine with the Flex, maybe I should report over at https://github.com/LedgerHQ/app-monero

Anyone else got one they can try?

[johnalanwoods]

Confirmed this is a CLI wallet bug, feather/Cake work fine.

[selsta]

@tobtoht any idea?

[tobtoht]

@selsta I don't have a Flex to test with.

@johnalanwoods Can you start CLI with --log-level 4 and report any relevant messages?

[johnalanwoods]

Certainly!