[WIP] Lint js and qml #4429
Open
[WIP] Lint js and qml #4429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b4n6-b4n6
force-pushed
the
lint-js-and-qml
branch
from
fffdec8 to
d9961da
Compare
b4n6-b4n6
force-pushed
the
lint-js-and-qml
branch
from
d9961da to
822a614
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related bounty
This PR intends to be a step towards improving the coding experience for the JS / QML files in the monero-gui codebase. This PR addresses the issue of the inconsistent use of semicolons in JS / QML files.
Justxd22's repostiory should be moved to some other account before this can be merged.
Also worth noting that QT SDK's
qmlformatseems to be an unhelpful (or I can't find the right page) tool as such I restorted toeslint