CMake: clearer sep. between the library and executable code #3858
Conversation
mj-xmr
force-pushed
the
wallet-gui-has-own-directory
branch
from
fce34ad to
0032cd0
Compare
| list(APPEND SOURCE_FILES "../qt/macoshelper.mm") | ||
| endif() | ||
|
|
||
| file(GLOB SOURCES_FOREIGN |
There was a problem hiding this comment.
Ideally this will go to separate libraries, but we're not there yet.
There was a problem hiding this comment.
I have seen your comment here, but I think if we merge this as is this get even more complicated and we are just moving files around at some point.
mj-xmr
force-pushed
the
wallet-gui-has-own-directory
branch
from
0aea1f8 to
8bdf8f4
Compare
mj-xmr
force-pushed
the
wallet-gui-has-own-directory
branch
from
8bdf8f4 to
323f225
Compare
| ${Qt5Gui_PRIVATE_INCLUDE_DIRS} | ||
| ) | ||
|
|
||
| target_link_libraries(${PROJECT} |
There was a problem hiding this comment.
This here should only link with wallet_api and ${QT5_LIBRARIES}. Everything else seems to be unrelated. Same with the unrelated foreign source files that get added.
|
One more thing to consider, inside the |
So I'm taking a closer look and it seems that it's all interconnected. Either I go all in and fix it all in one go, creating an unrealistically large PR, or we go step-by-step, leveraging "unlocked features" at each step. What's your choice? |
|
I don't know how you want to organize things so I can't really say at this point. Maybe you can make an overview? |
I'll get back to you on this one soon. |
Separated the (soon to be) testable library code from the GUI executable code and structured the dependencies better.
The project
monero-wallet-guinow inherits a lot of settings from the library projectwalletqt, so they don't have to be repeated in the executable's project files.