Refactor event handling #72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now event handlers can decide which handler will handle the next event. This change simplifies logic to decide who should be handling events by removing a unique, global, point of coordination that was not working well on some situations (e.g. the container menu) and it was quite fragile. It is also easier now to decide what is going to be shown on the screen. A thing that still needs to be solved is how to write unit tests for event handlers. It would also be good to find a design that will allow to get rid of global variables.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now event handlers can decide which handler will handle the next event.
This change simplifies logic to decide who should be handling events by
removing a unique, global, point of coordination that was not working
well on some situations (e.g. the container menu) and it was quite
fragile.
It is also easier now to decide what is going to be shown on the screen.
A few things still need a good solution: