Only add minus sign on largest unit of negative durations #1701
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diesieben07
requested changes
Apr 21, 2025
src/impl/formatter.js
Outdated
| default: | ||
| return null; | ||
| } | ||
| }, | ||
| tokenToString = (lildur) => (token) => { | ||
| const mapped = tokenToField(token); | ||
| if (mapped) { | ||
| return this.num(lildur.get(mapped), token.length); | ||
| const inversionFactor = lildur < 0 && mapped !== Object.keys(lildur.values)[0] ? -1 : 1; |
There was a problem hiding this comment.
- We should not rely on the order of keys in
lildur.values lildur < 0converts the duration to milliseconds every time. This should be done just once.
There was a problem hiding this comment.
- is there a more authoritative way? I'll look into this and write a patch.
- good catch, will patch.
There was a problem hiding this comment.
Not sure if there is an easy way. We'd have to find the index in orderedUnits. shiftTo happens here every time, can you check if that has a defined key order? But even if it does, it feels wrong to rely on that.
There was a problem hiding this comment.
shiftTo builds up values by looping through orderedUnits.
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per discussion #1699 (reply in thread)