Fix Daylight Savings parsing #396
Conversation
Previously the offset change for Daylight Savings was unnecessarily
added all the time, resulting in this discrepancy when the local time
was set to UTC-7:
```
Time.parse('2020-11-01 00:00:00')
=> 2020-11-01 00:00:00 -0700
Chronic.parse('2020-11-01 00:00:00')
=> 2020-11-01 01:00:00 -0700
```
Each time we add an offset to a base time, we need to check whether this
crosses Daylight Savings boundaries. Only if it does should we adjust
the time by the offset.
Closes mojombo#147
stanhu
force-pushed
the
sh-fix-daylight-savings-parsing
branch
from
26c5c25 to
d143986
Compare
|
@leejarvis Are you still maintaining this gem? If so, would you mind reviewing and pushing out an update? This bug causes a number of issues on gems that depend on it. |
He haven't been checking this for years. My unpublished |
|
|
||
| assert_nil Chronic.parse("1/1/32.1") | ||
|
|
||
| time = Chronic.parse("2020-11-01 00:00:00") |
There was a problem hiding this comment.
This tests your PR only when system's timezone is one you have, I have different one so for me this test passes either way even without your PR. Need to write such test that would test your specific case with your timezone.
|
I'm afraid I no longer have time to maintain Chronic. I'm more than open to adding more contributors if anyone is willing though |
3 participants
Previously the offset change for Daylight Savings was unnecessarily
added all the time, resulting in this discrepancy when the local time
was set to UTC-7:
Each time we add an offset to a base time, we need to check whether this
crosses Daylight Savings boundaries. Only if it does should we adjust
the time by the offset.
Closes #147