update-properties: the "includes" parameter is not used to filter the list of artefacts for which to search for updates

[troosan]

When using the use-latest-versions goal, we can pass an "includes" (or "includesList") parameter to limit the list of artefacts to update.
This filtering works fine, but, the plugin is losing a lot of time searching for updates for ALL dependences, then limiting the found updates.

This is a waste of time, can we not first limit the list, then search for any updates for the filtered list?

[andrzejj0]

Are you sure about that? I have just checked the code and see that it is checking whether a dependency matches include/exclude filters prior to attempting to find available updates to it.

See for yourself: https://github.com/mojohaus/versions/blob/master/versions-maven-plugin/src/main/java/org/codehaus/mojo/versions/UseLatestVersionsMojoBase.java#L238

As you can see, the plugin will output a debug log of Looking for newer versions of before checking for updates, which we can see back in an output of

mvn versions:use-latest-versions '-Dincludes=org.codehaus.plexus:plexus-xml' -NX

on its own repo (that is, on the versions maven plugin). In the above line, I'm limiting updates to org.codehaus.plexus:plexus-xml:* and the Maven scope to just the top pom.xml, so that it does not descend the reactor tree.

The debug output that follows shows that only org.codehaus.plexus:plexus-xml is checked for updates:

[DEBUG] Ignoring dependency with property as version: org.apache.maven:maven-plugin-api:jar:${mavenVersion}
[DEBUG] Ignoring dependency with property as version: org.apache.maven:maven-artifact:jar:${mavenVersion}
[DEBUG] Ignoring dependency with property as version: org.apache.maven:maven-core:jar:${mavenVersion}
[DEBUG] Ignoring dependency with property as version: org.apache.maven:maven-model:jar:${mavenVersion}
[DEBUG] Ignoring dependency with property as version: org.apache.maven:maven-model-builder:jar:${mavenVersion}
[DEBUG] Ignoring dependency with property as version: org.apache.maven:maven-settings:jar:${mavenVersion}
[DEBUG] Ignoring dependency with property as version: org.apache.maven:maven-compat:jar:${mavenVersion}
[DEBUG] Ignoring dependency with property as version: com.fasterxml.woodstox:woodstox-core:jar:${woodstoxVersion}
[DEBUG] Ignoring dependency with property as version: org.codehaus.woodstox:stax2-api:jar:${stax2ApiVersion}
[DEBUG] Ignoring dependency with property as version: org.apache.maven.resolver:maven-resolver-api:jar:${mavenResolverVersion}
[DEBUG] Ignoring dependency with property as version: org.apache.maven.resolver:maven-resolver-util:jar:${mavenResolverVersion}
[DEBUG] Ignoring dependency with property as version: org.eclipse.sisu:org.eclipse.sisu.plexus:jar:${sisuVersion}
[DEBUG] Ignoring dependency with property as version: org.eclipse.sisu:org.eclipse.sisu.inject:jar:${sisuVersion}
[DEBUG] Ignoring dependency with property as version: org.apache.maven.enforcer:enforcer-api:jar:${maven-enforcer-plugin.version}
[DEBUG] Ignoring dependency with property as version: org.apache.maven.reporting:maven-reporting-api:jar:${reportingApiVersion}
[DEBUG] Ignoring dependency with property as version: org.apache.maven.reporting:maven-reporting-impl:jar:${reportingImplVersion}
[DEBUG] Ignoring dependency with property as version: org.apache.maven.doxia:doxia-core:jar:${doxiaVersion}
[DEBUG] Ignoring dependency with property as version: org.apache.maven.doxia:doxia-sink-api:jar:${doxiaVersion}
[DEBUG] Ignoring dependency with property as version: org.apache.maven.doxia:doxia-integration-tools:jar:${doxia-sitetoolsVersion}
[DEBUG] Ignoring dependency with property as version: org.mockito:mockito-core:jar:${mockitoVersion}
[DEBUG] Ignoring dependency with property as version: org.mockito:mockito-inline:jar:${mockitoVersion}
[DEBUG] Ignoring dependency with property as version: org.mockito:mockito-junit-jupiter:jar:${mockitoVersion}
[DEBUG] Selected version:3.0.1
[DEBUG] Looking for newer versions of org.codehaus.plexus:plexus-xml:jar:3.0.1
[DEBUG] Could not find metadata org.codehaus.plexus:plexus-xml/maven-metadata.xml in local (/home/ono/.m2/repository)
[DEBUG] Skipped remote request for org.codehaus.plexus:plexus-xml/maven-metadata.xml, locally cached metadata up-to-date
[INFO] Updated org.codehaus.plexus:plexus-xml:jar:3.0.1 to version 4.1.0
[DEBUG] Ignoring dependency with property as version: net.bytebuddy:byte-buddy:jar:${byteBuddyVersion}
[DEBUG] Ignoring dependency with property as version: net.bytebuddy:byte-buddy-agent:jar:${byteBuddyVersion}
[DEBUG] ALL version changes allowed
[DEBUG] Backing up /home/ono/dev/versions-maven-plugin/pom.xml to /home/ono/dev/versions-maven-plugin/pom.xml.versionsBackup
[DEBUG] writing change record to /home/ono/dev/versions-maven-plugin/target/versions-changes.xml
[INFO] Copying org.codehaus.mojo.versions:versions:pom:2.19.1-SNAPSHOT to project local repository
[DEBUG] Reading file model from /home/ono/dev/versions-maven-plugin/pom.xml
[INFO] Copying org.codehaus.mojo.versions:versions:pom:consumer:2.19.1-SNAPSHOT to project local repository

Those Ignoring dependency lines indicate that a dependency matched the include/exclude lists and was skipped.

[troosan]

I’ll try to run in debug mode to see what’s happening. Thanks for the investigation.

[troosan]

@andrzejj0 I checked the logs a bit more. What actually triggers this is when building with -U
And I was wrong, it's not versions:2.19.0:use-latest-versions (that one works as expected) but versions:2.19.0:update-properties that has the problem

The plugin is downloading all dependencies (the list is super long)

Downloading from public: https://.../nexus/repository/public/io/asyncer/r2dbc-mysql/maven-metadata.xml
Downloaded from public: https://.../nexus/repository/public/org/htmlunit/htmlunit/maven-metadata.xml

Then

[INFO] Not updating the property ${htmlunit.version} because it is used by artifact org.htmlunit:htmlunit:jar:4.5.0 and that artifact is not included in the list of  allowed artifacts to be updated.

It does this for all dependencies, regardless if its in the list of allowed artifacts or not.

[andrzejj0]

It's Maven that's doing that, not the plugin. Please look more closely into the log, you will see that this fetching occurs before the Plugin is executed.

[troosan]

no, it is happening during the plugin execution.
BTW, it's working fin for versions:2.19.0:use-latest-versions, there it is downloading only the filtered artifacts (2 artifacts).

for versions:2.19.0:update-properties, all dependencies get downloaded

here's a (redacted) screenshot

[andrzejj0]

Ah, update-properties. Indeed, it looks like we have a problem there. Thanks.