Skip to content

Conversation

uchenily
Copy link
Contributor

This PR will extract executable name from shebang and correctly set the command-line parameters

@slawekjaranowski
Copy link
Member

Can we add some test for it?

@uchenily
Copy link
Contributor Author

Can we add some test for it?

Done.

@slawekjaranowski
Copy link
Member

As I see it is only used for environmentScript parameter ... so we need to update description of this parameter.

We have also an IT - src/it/projects/envscript we can add shebang to src/it/projects/envscript/src/build/env.sh

We also use command env in method createEnvWrapperFile so, shebang must be set to shell which support such command.

- Update description of environmentScript
- Make getShebang package private
- Add shebang line into env.sh
@uchenily
Copy link
Contributor Author

@slawekjaranowski thanks for your review suggestions. I have made some changes. Can you help me take a look again?

@slawekjaranowski slawekjaranowski merged commit 664d788 into mojohaus:master Sep 29, 2025
167 of 416 checks passed
@slawekjaranowski slawekjaranowski added this to the 3.6.0 milestone Sep 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants