#81 IllegalArgumentException when using goal released-version with maven 3.6.2/3.6.3 #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
bmarwell
reviewed
Feb 14, 2020
| @@ -0,0 +1,2 @@ | |||
| invoker.goals = test | |||
| invoker.buildResult = success No newline at end of file | |||
There was a problem hiding this comment.
Maybe a bit picky, but usually files end with a EOL.
There was a problem hiding this comment.
copied it over from the other ITs, it's the same there
i think this is really cosmetic...
There was a problem hiding this comment.
Yep. You might laugh, but when I tried to contribute to the Maven checkstyle plugin, those things are mentioned as well. 😅
Anyway, this does not block anything, just wanted to let you know. LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #81
added integration test to reproduce the problem and cherry-picked fix from @veikokaap from #82