[Puzzle 16] Update call to copy_dram_to_sram_async to address redundant memory operations #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… perform the copy even though the load layout specifies that only three should be used. PR adds extra parameters to fix this.
ehsanmok
approved these changes
Aug 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
copy_dram_to_sram_asyncdid not support 2d thread blocks before modular/modular#5068. As a result the async copy in the Idiomatic LayoutTensor tiling solution currently uses all9threads from the 2d thread block to perform the copy even though the load layout explicitley specifies3. PR adds extra parameters to fix this.