Skip to content

FIX-#7667: Fix axis=None case for DataFrame.rename #7674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 26, 2025
Merged

FIX-#7667: Fix axis=None case for DataFrame.rename #7674

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
23070f5
FIX-#7667: Fix `axis=None` case for `DataFrame.rename`
sfc-gh-dpetersohn Sep 19, 2025
98c7411
Address feedback
sfc-gh-dpetersohn Sep 19, 2025
d4bfa7b
Lint
sfc-gh-dpetersohn Sep 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions modin/pandas/dataframe.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1829,8 +1829,7 @@ def rename(
# inplace should always be true because this is just a copy, and we will use the
# results after.
kwargs["inplace"] = False
if axis is not None:
axis = self._get_axis_number(axis)
axis = self._get_axis_number(axis)
if index is not None or (mapper is not None and axis == 0):
new_index = pandas.DataFrame(index=self.index).rename(**kwargs).index
else:
Expand Down
1 change: 1 addition & 0 deletions modin/tests/pandas/dataframe/test_indexing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1150,6 +1150,7 @@ def test_rename_sanity():
modin_df.rename(str.upper, axis=1).columns,
df.rename(str.upper, axis=1).columns,
)
assert_index_equal(modin_df.rename(str.upper).index, df.rename(str.upper).index)

# have to pass something
with pytest.raises(TypeError):
Expand Down
Loading