Skip to content

TEST-#7629: Update code for mypy 1.17 #7630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 22, 2025
Merged

TEST-#7629: Update code for mypy 1.17 #7630

merged 1 commit into from
Jul 22, 2025

Conversation

sfc-gh-joshi
Copy link
Contributor

What do these changes do?

Fixes a mypy warning raised in the newest version.

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves CI: Update code for mypy 1.17 #7629
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

@sfc-gh-joshi sfc-gh-joshi changed the title CI-#7629: Update code for mypy 1.17 TEST-#7629: Update code for mypy 1.17 Jul 22, 2025
@sfc-gh-joshi sfc-gh-joshi merged commit 60d34ac into modin-project:main Jul 22, 2025
41 checks passed
@sfc-gh-joshi sfc-gh-joshi deleted the joshi/mypy-bump branch July 22, 2025 20:23
sfc-gh-vrpatel pushed a commit to sfc-gh-vrpatel/modin that referenced this pull request Jul 22, 2025
@sfc-gh-joshi @sfc-gh-vrpatel
TEST-modin-project#7629: Update code for mypy 1.17 (modin-project#7630)
f4f1c80 
Fixes a mypy warning raised in the newest version.

Signed-off-by: Jonathan Shi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sfc-gh-mvashishtha sfc-gh-mvashishtha sfc-gh-mvashishtha approved these changes

@devin-petersohn devin-petersohn Awaiting requested review from devin-petersohn devin-petersohn is a code owner

@mvashishtha mvashishtha Awaiting requested review from mvashishtha mvashishtha is a code owner

@RehanSD RehanSD Awaiting requested review from RehanSD RehanSD is a code owner

@YarShev YarShev Awaiting requested review from YarShev YarShev is a code owner

@vnlitvinov vnlitvinov Awaiting requested review from vnlitvinov vnlitvinov is a code owner

@anmyachev anmyachev Awaiting requested review from anmyachev anmyachev is a code owner

@dchigarev dchigarev Awaiting requested review from dchigarev dchigarev is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CI: Update code for mypy 1.17

2 participants

@sfc-gh-joshi @sfc-gh-mvashishtha