FIX-#7616: Implement __array_function__ stub #7617
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jonathan Shi <[email protected]>
sfc-gh-joshi
requested review from
a team,
RehanSD,
YarShev,
anmyachev,
dchigarev,
devin-petersohn,
mvashishtha and
vnlitvinov
as code owners
9 tasks
sfc-gh-mvashishtha
approved these changes
Jun 28, 2025
sfc-gh-jkew
reviewed
Jun 28, 2025
| The result of applying the function to this dataset. By default, it will return | ||
| a NumPy array. | ||
| """ | ||
| return self._query_compiler.do_array_function_implementation( |
There was a problem hiding this comment.
Out of curiosity; what would happen here if you just returned the NotImplemented sentinel? Would this be a way to avoid calling __array__()?
There was a problem hiding this comment.
TypeError: no implementation found for 'numpy.where' on types that implement __array_function__: [<class 'modin.pandas.dataframe.DataFrame'>]
I think numpy only explicitly calls __array__ if no __array_function__ implementation is available.
sfc-gh-joshi
added a commit
to snowflakedb/snowpark-python
that referenced
this pull request
Jun 30, 2025
…nd native Series constructor switching bugs (#3498) SNOW-2157873 occurs because upstream modin does not implement __array_function__, instead converting to numpy ndarrays via __array__ when a numpy function is called on it. The presence of the extension wrapper for __array_function__ introduced by Snowpark pandas confuses numpy dispatch, causing unexpected AttributeErrors. This is fixed upstream with modin-project/modin#7617, and will presumably become available in the next modin release. On the Snowpark side, this PR adds relevant tests, and adds a version-guarded flag to remove the extension function and push it down to the query compiler. SNOW-2173644 occurs in specific circumstances when determining switching conditions for the DataFrame constructor. Series objects are treated as dict-like, but Series.values is a property rather than a function. We thus skip over native_pd.Series objects in the dict-like check in move_to_me_cost.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Implements
__array_function__to prevent errors when a backend implements the function as an extension method. See linked issue for details.flake8 modin/ asv_bench/benchmarks scripts/doc_checker.pyblack --check modin/ asv_bench/benchmarks scripts/doc_checker.pygit commit -sdocs/development/architecture.rstis up-to-date