FIX-#7611: Display 'modin.pandas' instead of 'None' in backend switching information. #7612
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…' in backend switching logs - Updated logging in _get_backend_for_auto_switch to show 'modin.pandas' instead of 'None' when class_of_wrapped_fn is None - Updated corresponding tests to expect the correct log message format - Functions in the modin.pandas module now properly display their module name in backend switching logs
…_operation - Fixed switch_operation parameter construction in three locations in query_compiler_caster.py - All instances now use 'modin.pandas' instead of 'None' when class_of_wrapped_fn is None - This resolves progress bar messages showing 'None.read_snowflake' instead of 'modin.pandas.read_snowflake' - Fixes the progress bar issue mentioned by the user where backend switching shows None Related to issue modin-project#7611
… names - Added MODIN_PANDAS_MODULE_NAME constant to centralize the magic string - Created _normalize_class_name() helper function to handle None -> 'modin.pandas' conversion - Replaced all manual None checks with calls to the helper function - Reduces code duplication and makes maintenance easier - No functional changes, all tests still pass This improves code maintainability by having a single source of truth for the 'modin.pandas' string and eliminates repetitive None-checking logic.
Verify that progress bar messages show the correct switch_operation (e.g., 'modin.pandas.read_json') instead of 'None.read_json' when backend switching occurs with the switch_operation parameter. Also fix import sorting and remove unused imports in test_compiler_caster.py.
Only keep the new progress bar test in test_backend.py
…ssage - Rename test_progress_bar_shows_switch_operation_correctly to test_progress_bar_message - Parametrize by switch_operation including None case - Check complete message format instead of just presence/absence of strings - Verify exact expected format: 'Transferring data from Ray to Pandas for <operation>' or without operation when None
- Revert test_backend.py changes to keep it focused on backend API - Add test_progress_bar_shows_modin_pandas_for_general_functions to test_compiler_caster.py - Verifies that automatic backend switching for general functions like read_json shows 'modin.pandas.read_json' instead of 'None.read_json' in progress bar messages - Ensures our fix for issue modin-project#7611 prevents 'None.read_snowflake' type messages
- Remove unnecessary variable and verbose comment - Check message starts with correct format directly - Ensures 'modin.pandas.read_json' appears instead of 'None.read_json'
sfc-gh-mvashishtha
changed the title
sfc-gh-mvashishtha
changed the title
- Remove test_progress_bar_shows_switch_operation_correctly from test_backend.py - Keep test_backend.py focused on backend API functionality only - Progress bar testing is now properly handled in test_compiler_caster.py
sfc-gh-mvashishtha
requested review from
a team,
RehanSD,
YarShev,
anmyachev,
dchigarev,
devin-petersohn,
mvashishtha and
vnlitvinov
as code owners
sfc-gh-joshi
approved these changes
Jun 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Display
"modin.pandas"instead of"None"in backend switching logs and progress bars.Resolves #7611