Skip to content

Conversation

sfc-gh-mvashishtha
Copy link
Contributor

Resolves #7607

Copy link
Contributor

@sfc-gh-joshi sfc-gh-joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one high-level question I want to make sure of: do we want a groupby object's pin status to be permanently separate from that of its parent object, as it is in this PR?

df = pd.DataFrame(...).pin_backend()
groupby = df.groupby(...)  # should be pinned
df.unpin_backend(inplace=True)  # should not affect the pin status of the groupby object

@sfc-gh-mvashishtha
Copy link
Contributor Author

do we want a groupby object's pin status to be permanently separate from that of its parent object, as it is in this PR?

That behavior makes more sense to me. I'm introducing inconsistency in this PR because we made the opposite choice for the indexer objects. Eventually, I prefer to align the indexer classes with the behavior here.

@sfc-gh-mvashishtha sfc-gh-mvashishtha merged commit e4083eb into modin-project:main Jun 18, 2025
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support grouping pinned objects by supporting pinning groupby objects in place

2 participants