Skip to content

FEAT-#7606: Consider self_cost in hybrid casting calculator #7605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 10, 2025
Merged

FEAT-#7606: Consider self_cost in hybrid casting calculator #7605

merged 7 commits into from
Jun 10, 2025

Conversation

sfc-gh-jkew
Copy link
Contributor

@sfc-gh-jkew sfc-gh-jkew commented Jun 9, 2025 •
edited
Loading

What do these changes do?

Currently the BackendCostCalculator only considers move_to and move_to_me costs. We update this so the costing calculation considers the execution cost if the data does not move.

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves Consider self_cost in BackendCostCalculator for casting scenarios #7606
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

@sfc-gh-jkew sfc-gh-jkew changed the title Jkew/add self cost FEAT #7606: Consider self_cost in casting calculator Jun 9, 2025
@sfc-gh-jkew sfc-gh-jkew changed the title FEAT #7606: Consider self_cost in casting calculator FEAT-#7606: Consider self_cost in casting calculator Jun 9, 2025
@sfc-gh-jkew sfc-gh-jkew changed the title FEAT-#7606: Consider self_cost in casting calculator FEAT-#7606: Consider self_cost in hybrid casting calculator Jun 9, 2025
@sfc-gh-jkew sfc-gh-jkew marked this pull request as ready for review June 10, 2025 14:23
@sfc-gh-jkew sfc-gh-jkew merged commit a247e27 into main Jun 10, 2025
84 of 87 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sfc-gh-mvashishtha sfc-gh-mvashishtha sfc-gh-mvashishtha approved these changes

@devin-petersohn devin-petersohn Awaiting requested review from devin-petersohn devin-petersohn is a code owner

@mvashishtha mvashishtha Awaiting requested review from mvashishtha mvashishtha is a code owner

@RehanSD RehanSD Awaiting requested review from RehanSD RehanSD is a code owner

@YarShev YarShev Awaiting requested review from YarShev YarShev is a code owner

@vnlitvinov vnlitvinov Awaiting requested review from vnlitvinov vnlitvinov is a code owner

@anmyachev anmyachev Awaiting requested review from anmyachev anmyachev is a code owner

@dchigarev dchigarev Awaiting requested review from dchigarev dchigarev is a code owner

Assignees

No one assigned

Labels

hybrid-execution

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Consider self_cost in BackendCostCalculator for casting scenarios

2 participants

@sfc-gh-jkew @sfc-gh-mvashishtha