Skip to content

Conversation

@mpeleshenko
Copy link
Contributor

What do these changes do?

Ensure empty Dataframes with pyarrow dtypes maintain the dtype metadata.

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves BUG: Dataframe.dtypes is NaN for empty Dataframes with pyarrow dtypes #7569
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

Copy link
Contributor

@sfc-gh-joshi sfc-gh-joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. CI failure looks unrelated, I'll investigate.

@sfc-gh-joshi
Copy link
Contributor

@mpeleshenko Could you rebase your branch on latest main? I've skipped the test that's breaking CI.

@mpeleshenko mpeleshenko force-pushed the fix-empty-dataframe-pyarrow-dtypes branch from 69fe13f to e2166de Compare May 15, 2025 22:45
@sfc-gh-joshi sfc-gh-joshi merged commit 25a7a9a into modin-project:main May 16, 2025
41 checks passed
@mpeleshenko mpeleshenko deleted the fix-empty-dataframe-pyarrow-dtypes branch May 16, 2025 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: Dataframe.dtypes is NaN for empty Dataframes with pyarrow dtypes

2 participants