FEAT-#7549: Emit metrics on auto-switch and casting behavior #7550
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-jkew
requested review from
a team,
RehanSD,
YarShev,
anmyachev,
dchigarev,
devin-petersohn,
mvashishtha and
vnlitvinov
as code owners
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
sfc-gh-joshi
reviewed
May 1, 2025
sfc-gh-jkew
added a commit
to snowflakedb/snowpark-python
that referenced
this pull request
May 10, 2025
| f"BackendCostCalculator Results: {self._calc_result_log(self._result_backend)}" | ||
| ) | ||
| # Does not need to be secure, should not use system entropy | ||
| metrics_group = "%04x" % random.randrange(16**4) |
There was a problem hiding this comment.
This was originally a monotonic counter, right? Why is it random now?
…dom hex for the group instead of variable.
sfc-gh-joshi
force-pushed
the
jkew/emit-hybrid-metrics
branch
from
9fcc377 to
1ed78a2
Compare
sfc-gh-mvashishtha
approved these changes
May 22, 2025
sfc-gh-joshi
pushed a commit
to snowflakedb/snowpark-python
that referenced
this pull request
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In both the caster and the calculator we emit some new metrics to track the switching behavior. This will be used by a metrics handler to implement debugging tools.
flake8 modin/ asv_bench/benchmarks scripts/doc_checker.pyblack --check modin/ asv_bench/benchmarks scripts/doc_checker.pygit commit -sdocs/development/architecture.rstis up-to-date