Skip to content

TEST-#7419: Fix CI #7420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jan 16, 2025
Merged

TEST-#7419: Fix CI #7420

merged 8 commits into from
Jan 16, 2025

Conversation

@sfc-gh-mvashishtha
Copy link
Contributor

@sfc-gh-mvashishtha sfc-gh-mvashishtha commented Jan 11, 2025

What do these changes do?

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves Fix CI, including mypy "incompatible return type" error in modin/__init__.py:64:12 #7419
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

@anmyachev
Copy link
Collaborator

anmyachev commented Jan 14, 2025

Setting up libmpich-dev:amd64 (4.0-3) ... works but Setting up libmpich-dev:amd64 (4.2.0-5build3) doesn't work. I think the following change can help to fix mpi issue: sudo apt install libmpich-dev -> sudo apt install libmpich-dev<4.2

@sfc-gh-mvashishtha
Cap libmpich-dev under 4.2
0aea0ae 
Signed-off-by: sfc-gh-mvashishtha <[email protected]>
anmyachev
anmyachev reviewed Jan 15, 2025
View reviewed changes
@sfc-gh-mvashishtha
Pin libmpich-dev to 4.0-3
22f4a24 
Signed-off-by: sfc-gh-mvashishtha <[email protected]>
@sfc-gh-mvashishtha sfc-gh-mvashishtha changed the title TEST-#7419: Fix mypy TEST-#7419: Fix CI Jan 15, 2025
@sfc-gh-mvashishtha sfc-gh-mvashishtha mentioned this pull request Jan 15, 2025
Closed
anmyachev
anmyachev previously approved these changes Jan 15, 2025
View reviewed changes
@sfc-gh-mvashishtha sfc-gh-mvashishtha marked this pull request as ready for review January 16, 2025 00:14
@sfc-gh-mvashishtha sfc-gh-mvashishtha merged commit caa6116 into modin-project:main Jan 16, 2025
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anmyachev anmyachev anmyachev approved these changes

@devin-petersohn devin-petersohn Awaiting requested review from devin-petersohn devin-petersohn is a code owner

@mvashishtha mvashishtha Awaiting requested review from mvashishtha mvashishtha is a code owner

@RehanSD RehanSD Awaiting requested review from RehanSD RehanSD is a code owner

@YarShev YarShev Awaiting requested review from YarShev YarShev is a code owner

@vnlitvinov vnlitvinov Awaiting requested review from vnlitvinov vnlitvinov is a code owner

@dchigarev dchigarev Awaiting requested review from dchigarev dchigarev is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix CI, including mypy "incompatible return type" error in modin/__init__.py:64:12

2 participants

@sfc-gh-mvashishtha @anmyachev