Skip to content

Conversation

@noloerino
Copy link
Collaborator

What do these changes do?

The sort parameter of DataFrame.stack was exposed in pandas docs in 2.1.0, but we didn't link it from the frontend to the query compiler.

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves Pass sort parameter in stack to query_compiler from modin/pandas/dataframe.py #7327
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

@noloerino noloerino force-pushed the joshi/7327-stack-sort branch from 88afe4a to b947be3 Compare September 12, 2024 23:34
@noloerino noloerino changed the title FIX-7327: Use sort parameter of DataFrame.stack FIX-#7327: Use sort parameter of DataFrame.stack Sep 12, 2024
@noloerino noloerino force-pushed the joshi/7327-stack-sort branch from b947be3 to 5b50045 Compare September 19, 2024 20:39
@anmyachev anmyachev merged commit 1c4d173 into modin-project:main Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pass sort parameter in stack to query_compiler from modin/pandas/dataframe.py

2 participants