PERF-#6556: do window block-wise #6290
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christinafan
changed the title
naive implementation working on efficiency improvements efficiency has bugs some fixes, errors inside window_function_partition some fixes, issue with num virtual partitions fixed map function error hopefully fixed row-wise fixed row actually? removed debugging comments attempting to fix col-wise removing debugging comments row window operations work fixed col ops query compiler changes removing print statements query compiler changes more query compiler changes center fix work in progress continued center fixes attempting to fix bugs update fixed errors corr changes but still broken forgot to push corr and cov changes
Signed-off-by: mvashishtha <[email protected]>
mvashishtha
reviewed
Jul 14, 2023
There was a problem hiding this comment.
@christinafan I'm leaving some minor comments.
Before pushing again, you should test with:
pytest modin/pandas/test/test_rolling.py -n 8 --execution=PandasOnRay
pytest modin/pandas/test/test_rolling.py -n 8 --execution=BaseOnPython
mvashishtha
changed the title
Signed-off-by: Mahesh Vashishtha <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
flake8 modin/ asv_bench/benchmarks scripts/doc_checker.pyblack --check modin/ asv_bench/benchmarks scripts/doc_checker.pygit commit -sdocs/development/architecture.rstis up-to-date