-
Notifications
You must be signed in to change notification settings - Fork 666
PERF-#4493: Use partition size caches more in Modin dataframe. #4495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PERF-#4493: Use partition size caches more in Modin dataframe. #4495
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4495 +/- ##
===========================================
- Coverage 86.65% 65.75% -20.91%
===========================================
Files 226 229 +3
Lines 18311 19606 +1295
===========================================
- Hits 15868 12892 -2976
- Misses 2443 6714 +4271
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, great catch!
39d9e8b
to
d883c0b
Compare
@devin-petersohn I also added a change to use the base frame's size caches when possible. Please take a look. I saw it eliminate the single-threaded portion here. |
…frame. Signed-off-by: mvashishtha <[email protected]>
Signed-off-by: mvashishtha <[email protected]>
Signed-off-by: mvashishtha <[email protected]>
Signed-off-by: mvashishtha <[email protected]>
Signed-off-by: mvashishtha <[email protected]>
Signed-off-by: mvashishtha <[email protected]>
…e in concat. Signed-off-by: mvashishtha <[email protected]>
3fe7a12
to
6554633
Compare
Signed-off-by: mvashishtha <[email protected]>
Signed-off-by: mvashishtha <[email protected]>
Signed-off-by: mvashishtha <[email protected]>
Signed-off-by: mvashishtha <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mvashishtha This is awesome, I left a couple of nits
Signed-off-by: mvashishtha <[email protected]>
Co-authored-by: Devin Petersohn <[email protected]> Co-authored-by: Yaroslav Igoshev <[email protected]>
Signed-off-by: mvashishtha <[email protected]>
Signed-off-by: mvashishtha <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mvashishtha, LGTM, thanks!
Signed-off-by: mvashishtha [email protected]
What do these changes do?
flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
git commit -s
docs/development/architecture.rst
is up-to-date