[grpo] model weight synchronization before first turn rollout with async generation #4584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjh0119
changed the title
tastelikefeet
approved these changes
Jun 12, 2025
Jintao-Huang
approved these changes
Jun 12, 2025
Jintao-Huang
pushed a commit
that referenced
this pull request
Jun 13, 2025
…ync generation (#4584) * sync-weight-in-async-generate * fix wait
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR type
PR information
fix a bug when use
async_generate, the model will not sync weight to vllm engine before first turn rolloutExperiment results
Paste your experiment result here(if needed).