Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion swift/llm/dataset/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ def __getitem__(self, idx: int) -> Dict[str, Any]:
try:
return self.encode_func(data)
except Exception:
if n_try == self.n_try_fetch - 1:
if n_try == self.n_try_fetch - 1 or self.strict:
if self.strict:
logger.warning('To avoid errors, you can pass `strict=False`.')
raise
Expand Down
5 changes: 5 additions & 0 deletions swift/megatron/argument/megatron_args.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,9 @@
from dataclasses import asdict, dataclass, field
from typing import Any, Dict, List, Literal, Optional, Tuple, Union

import megatron.core
import torch
from packaging import version
from transformers.utils.versions import require_version

from swift.llm.argument.base_args import to_abspath
Expand Down Expand Up @@ -133,6 +135,7 @@ class MegatronArguments(ExtraMegatronArguments):
moe_z_loss_coeff: Optional[float] = None
moe_expert_capacity_factor: Optional[float] = None
moe_shared_expert_overlap: bool = False
moe_layer_recompute: bool = False

# mixed precision
fp16: Optional[bool] = None
Expand Down Expand Up @@ -231,6 +234,8 @@ def _args_to_argv(self) -> Tuple[List[Any], Dict[str, Any]]:
args_dict = asdict(self)
extra_args = {}
for k, value in args_dict.items():
if k == 'recompute_modules' and version.parse(megatron.core.__version__) < version.parse('0.12'):
continue
if k not in MegatronArguments.__annotations__:
extra_args[k] = value
continue
Expand Down
Loading