-
Notifications
You must be signed in to change notification settings - Fork 215
[Fix] Fix reasoning content #797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @Yunnglin, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses an issue related to the handling and display of reasoning content from model responses. It updates how message content is extracted and processed, specifically allowing for the exclusion of reasoning details when converting OpenAI chat choices. Additionally, it refactors how responses are handled in the tau_bench adapter and updates benchmark tests to reflect new model and streaming parameters.
Highlights
- Conditional Reasoning Content: This change ensures that reasoning content can be optionally excluded when processing OpenAI chat messages, providing more control over the output.
- Message Content Extraction: The method of extracting message content was updated from
.contentto.textin the BFCL benchmark generation, adapting to potential changes in message object structure. - Tau Bench Adapter Refinement: The Tau Bench adapter was refined to directly utilize
res.completionfor message content, simplifying the handling of model responses. - Benchmark Test Updates: Benchmark tests for BFCL and Tau Bench were updated to use a specific model (
qwq-plus) and enable streaming, aligning with new testing requirements or model capabilities.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request primarily focuses on fixing how reasoning content is handled, by making its inclusion in model outputs optional. This is implemented by adding an include_reasoning flag to several utility functions. The changes also include refactoring how message content is accessed, switching from .content to the more robust .text property, which is a good improvement. Additionally, a bug in tau_bench_adapter.py is fixed to ensure a string is always returned, though this introduces a potential issue with message history that I've commented on. The test configurations have also been updated accordingly. Overall, these are good fixes that improve correctness and add flexibility.
* fix reasoning * fix reasoning
see #791