Skip to content

Conversation

@Yunnglin
Copy link
Collaborator

No description provided.

@Yunnglin Yunnglin marked this pull request as ready for review June 24, 2025 12:29
@Yunnglin Yunnglin requested a review from Copilot June 25, 2025 08:42
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors and modularizes the visualization and UI logic for the Evalscope dashboard, extracts shared utilities, and cleans up the main application module. Key changes include:

  • Breaking out UI components into app/ui submodules and consolidating create_app_ui.
  • Adding visualization and text‐processing utilities under app/utils.
  • Minor fixes in tests (test_run.py) and the server adapter (server_adapter.py).

Reviewed Changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
tests/cli/test_run.py Updated default model to qwen-max and enabled additional datasets.
evalscope/models/adapters/server_adapter.py Fixed API key reference to use self.api_key.
evalscope/app/utils/visualization.py Added charting helpers for bar, sunburst, and radar plots.
evalscope/app/utils/text_utils.py Introduced markdown/text conversion utilities.
evalscope/app/utils/localization.py Centralized locale lookups for sidebar and visualization.
evalscope/app/utils/data_utils.py Extracted data loading/processing logic into utilities.
evalscope/app/ui/visualization.py Created top‐level visualization container with tabs.
evalscope/app/ui/single_model.py Moved single‐model UI and interactions into its own module.
evalscope/app/ui/multi_model.py Moved multi‐model UI and comparison logic into its own module.
evalscope/app/ui/sidebar.py Extracted sidebar layout and report scanning interactions.
evalscope/app/ui/app_ui.py Added create_app_ui entry point for assembling the UI.
evalscope/app/app.py Cleaned up and delegated to create_app_ui; removed duplication.
docs/generate_dataset_md.py Updated dataset markdown generator to use localized helpers.
docs/en/get_started/supported_dataset/llm.md Fixed table header underline length to match columns.
Comments suppressed due to low confidence (1)

evalscope/app/utils/visualization.py:18

  • [nitpick] This utility lacks a docstring. Consider adding a brief description of its purpose, parameters, and return value.
def plot_single_report_scores(df: pd.DataFrame):

@Yunnglin Yunnglin merged commit b4cec83 into main Jun 25, 2025
3 checks passed
@Yunnglin Yunnglin deleted the refact/app branch June 25, 2025 10:56
yucc-leon pushed a commit to yucc-leon/evalscope that referenced this pull request Oct 27, 2025
* split file

* split ui

* update utils

* add model compare

* add model compare ui

* add model compare name

* update generate dataset

* Update evalscope/app/utils/visualization.py

Co-authored-by: Copilot <[email protected]>

* Update evalscope/app/utils/data_utils.py

Co-authored-by: Copilot <[email protected]>

* Update evalscope/app/utils/visualization.py

Co-authored-by: Copilot <[email protected]>

* fix app

* fix app

---------

Co-authored-by: Copilot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants