Allow setting continuous states in Continuous Time Mode #1956
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
via fmi3SetFloat64() fixes modelica#1952
chrbertsch
reviewed
Jun 18, 2024
|
|
||
| Function <<get-and-set-variable-values,`fmi3Set{VariableType}`>>:: | ||
| Only for variables with <<causality>> = <<input>> and <<variability>> = <<continuous>>. | ||
| Only for variables with <<causality>> = <<input>> and <<variability>> = <<continuous>>, and <<state,continuous-time states>>. |
Collaborator
There was a problem hiding this comment.
Suggested change
| Only for variables with <<causality>> = <<input>> and <<variability>> = <<continuous>>, and <<state,continuous-time states>>. | |
| Only for variables with <<variability>> = <<continuous>> and either <<causality>> = <<input>> or <<state,continuous-time states>>. |
Collaborator
There was a problem hiding this comment.
After discussion with Torsten, I agree that the original proposal with ", and <<state,continuous-time states>>." is better English
chrbertsch
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
via fmi3SetFloat64()
fixes #1952