Skip to content

Conversation

@klausschuch
Copy link
Collaborator

No description provided.

@klausschuch klausschuch changed the title Draft; Add combitables Draft: Add combitables May 19, 2025
Copy link

@elmir-nahodovic elmir-nahodovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • In [[combitable1d_example]], what is x.0 referencing? Shouldn't that entry in the example be empty?
  • I think the link https://doc.modelica.org/om/Modelica.Blocks.Tables.html is outdated, and should at least be replaced by one for Modelica 4.0, https://doc.modelica.org/Modelica%204.0.0/Resources/helpDymola/Modelica_Blocks_Tables.html#Modelica.Blocks.Tables
  • (Maybe a general comment on ls-struct) Are the variables with prefix in_/out_ supposed to be added to the FMU by the exporter for each input variable of the tables? Or is it up to the model to contain these variables?
    • For example in [[combitable2d_example]], the terminalsAndIcons.xml gives that in_x is a domain input, but is that variable included in the model that was exported or is it added by the FMU ?
  • Since this is Modelica focused, it would be good to use a specific model containing combitables
    • Like the one provided by TorstenBlochwitz in #18, but in the example section
    • It would also be constructive if one combitable example matched example 4.2. 2-d example of a lookup table on a rectilinear grid
      • To show the map both with the context of combitables compared to the general context of ls-struct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants