Add reading of CSV files from ModelicaTableAdditions to ModelicaStandardTables #3691
Conversation
beutlich
added
enhancement
beutlich
requested review from
HansOlsson,
MartinOtter,
dietmarw and
sjoelund
beutlich
force-pushed
the
add-csv
branch
4 times, most recently
from
fb6c967 to
dd505cb
Compare
|
I updated the binaries in my branch "update-binaries-add-csv". Use https://github.com/beutlich/ModelicaStandardLibrary/tree/update-binaries-add-csv if you want to test it. |
|
Could it be that you forgot to add some test models that are reading the CSV files that were added? |
Yes, I will add them, but wanted to gather some early feedback from library officers first. At least I it is covered by CI. |
|
Sorry, currently have no time to inspect this in detail and therefore removed me as Reviewers |
@dietmarw I've just added the test models to ModelicaTest. If you want to test with Dymola 2021x make sure to set |
dietmarw
left a comment
dietmarw
left a comment
There was a problem hiding this comment.
Approved.
Note Advanced.PlaceDymolaSourceFirst = 2; was also necessary for Dymola 2020
HansOlsson
left a comment
HansOlsson
left a comment
There was a problem hiding this comment.
Seems good.
I tried rebuilding binaries and running test-case and the result matched the csv-file.
* Accept CSV files with EOL=CRLF on Linux * Accept CSV files with trailing white-space
beutlich
changed the title
4 participants
Taken from prototype implementation of ModelicaTableAdditions. Note, that no additional external 3-rd party dependencies are utilized. CSV tables with quoted values or line breaks are not supported.