-
Notifications
You must be signed in to change notification settings - Fork 495
Fix ResourceLinkBlock deserialization by adding missing "name" case #645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+87
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: eiriktsarpalis <[email protected]>
Co-authored-by: eiriktsarpalis <[email protected]>
Copilot finished work on behalf of
eiriktsarpalis
July 23, 2025 12:55
Co-authored-by: eiriktsarpalis <[email protected]>
Copilot finished work on behalf of
eiriktsarpalis
July 23, 2025 15:13
eiriktsarpalis
approved these changes
Jul 23, 2025
stephentoub
reviewed
Jul 23, 2025
stephentoub
approved these changes
Jul 23, 2025
Co-authored-by: stephentoub <[email protected]>
Co-authored-by: stephentoub <[email protected]>
Co-authored-by: stephentoub <[email protected]>
Copilot finished work on behalf of
stephentoub
July 23, 2025 16:18
This was referenced Aug 21, 2025
Merged
microsoft-github-policy-service bot
pushed a commit
to Azure/bicep
that referenced
this pull request
Aug 25, 2025
…7897) Updated [ModelContextProtocol](https://github.com/modelcontextprotocol/csharp-sdk) from 0.3.0-preview.2 to 0.3.0-preview.4. <details> <summary>Release notes</summary> _Sourced from [ModelContextProtocol's releases](https://github.com/modelcontextprotocol/csharp-sdk/releases)._ ## 0.3.0-preview.4 ## What's Changed * Respect HandleResponse() and SkipHandler() calls in OnResourceMetadataRequest by @halter73 in modelcontextprotocol/csharp-sdk#607 * UnreferenceDisposable made slimmer by @Scooletz in modelcontextprotocol/csharp-sdk#627 * IdleTracking uses lists instead of SortedSet by @Scooletz in modelcontextprotocol/csharp-sdk#629 * Fix ResourceLinkBlock deserialization by adding missing "name" case by @Copilot in modelcontextprotocol/csharp-sdk#645 * Add an in-memory transport sample by @stephentoub in modelcontextprotocol/csharp-sdk#664 * Remove 'Sse' from AspNetCoreSseServer sample name by @halter73 in modelcontextprotocol/csharp-sdk#665 * Fix NotSupportedException when returning IEnumerable<ContentBlock> by @Copilot in modelcontextprotocol/csharp-sdk#675 * Enhance HTTP and MCP session logging by @theojiang25 in modelcontextprotocol/csharp-sdk#608 * Remove special-casing of string enumerables in McpServerTool by @stephentoub in modelcontextprotocol/csharp-sdk#699 * Prune idle sessions before starting new ones by @halter73 in modelcontextprotocol/csharp-sdk#701 * Add framework for conceptual docs by @mikekistler in modelcontextprotocol/csharp-sdk#708 ## New Contributors * @Scooletz made their first contribution in modelcontextprotocol/csharp-sdk#627 * @Copilot made their first contribution in modelcontextprotocol/csharp-sdk#645 * @theojiang25 made their first contribution in modelcontextprotocol/csharp-sdk#608 **Full Changelog**: modelcontextprotocol/csharp-sdk@v0.3.0-preview.3...v0.3.0-preview.4 ## 0.3.0-preview.3 ## What's Changed * Enable netfx testing. by @eiriktsarpalis in modelcontextprotocol/csharp-sdk#588 * fix: Prevent crash when Options.ResourceMetadata is null but handled by event by @DavidParks8 in modelcontextprotocol/csharp-sdk#603 * Update to M.E.AI 9.7.0 by @stephentoub in modelcontextprotocol/csharp-sdk#602 * Ensure IsExternalInit is type forwarded on NET builds by @stephentoub in modelcontextprotocol/csharp-sdk#619 * Flow ExecutionContext with JsonRpcMessage by @halter73 in modelcontextprotocol/csharp-sdk#616 * Update MEAI version and add regression test for #601. by @eiriktsarpalis in modelcontextprotocol/csharp-sdk#628 ## New Contributors * @DavidParks8 made their first contribution in modelcontextprotocol/csharp-sdk#603 **Full Changelog**: modelcontextprotocol/csharp-sdk@v0.3.0-preview.2...v0.3.0-preview.3 Commits viewable in [compare view](modelcontextprotocol/csharp-sdk@v0.3.0-preview.2...v0.3.0-preview.4). </details> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> ###### Microsoft Reviewers: [Open in CodeFlow](https://microsoft.github.io/open-pr/?codeflow=https://github.com/Azure/bicep/pull/17897) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This was referenced Aug 25, 2025
ouvreboite
pushed a commit
to ouvreboite/csharp-sdk
that referenced
this pull request
Aug 26, 2025
…odelcontextprotocol#645) * Initial plan * Initial analysis and plan for ResourceLinkBlock deserialization fix Co-authored-by: eiriktsarpalis <[email protected]> * Fix ResourceLinkBlock deserialization by adding missing "name" case Co-authored-by: eiriktsarpalis <[email protected]> * Remove unnecessary dotnet-install.sh file Co-authored-by: eiriktsarpalis <[email protected]> * Use const for JSON string variables and improve indentation Co-authored-by: stephentoub <[email protected]> * Remove temporary backup file Co-authored-by: stephentoub <[email protected]> * Change JSON variable names to use PascalCase (Json) as requested Co-authored-by: stephentoub <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: eiriktsarpalis <[email protected]> Co-authored-by: stephentoub <[email protected]>
This was referenced Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed a critical deserialization bug in
ResourceLinkBlock
where the "name" property was not being read from JSON, causing aJsonException
to be thrown during deserialization.Problem
When attempting to deserialize a
ResourceLinkBlock
from JSON, the following exception was thrown:This occurred because the
ContentBlock.Converter.Read
method was missing a switch case for the "name" property, even though:name
variable was declared (line 75)name
property was being written correctly during serialization (line 245)name
variable was expected to be non-null when creating theResourceLinkBlock
(line 178)Root Cause
In
src/ModelContextProtocol.Core/Protocol/ContentBlock.cs
, the switch statement in theRead
method (lines 96-140) was missing a case for"name"
, causing the name property to remainnull
during deserialization.Solution
Added the missing switch case to properly handle the "name" property during JSON deserialization:
Testing
ResourceLinkBlock
now serializes and deserializes correctlyuri
,name
) are preserved during round-trip serializationdescription
,mimeType
,size
) are also handled correctlyContentBlockTests.cs
to prevent regressionContentBlock
types (TextContentBlock
,ImageContentBlock
, etc.) continue to work correctlyExample
Before this fix:
After this fix:
Fixes #644.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
aka.ms
curl -I -sSL --retry 5 --retry-delay 2 --connect-timeout 15 REDACTED
(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.