fix: Add error handling for nonexistent file case with --file option #5086

khoaHyh · 2024-01-24T06:54:48Z

🔎 Overview

Added validation to the file(s) passed in to the --file option by resolving the argument to an absolute path and check for its existence. We now log a warning and exit if the file does not exist.
- the errors for --require bubble up to the middleware in lib/cli/run.js. See here. This specific error occurs in lib/cli/run-helpers.js in the singleRun method when we load files asynchronously. Since we were lacking error handling there, the errors appeared the way they previously did before these changes.
Added a test to assert our changes

- added error handling when using the --file flag to do it the way --require does - added a test to assert that we throw the same type of error

linux-foundation-easycla · 2024-01-24T06:54:52Z

The committers listed above are authorized under a signed CLA.

✅ login: khoaHyh / name: Khoa Huynh (cf69df1, f8aedff, 8983b84, 4aad184, 645e0b0, 8423875, 21e566d, bd47d79, 909834d, 9685b82, 1a9f155, b6d6dc2, ea092be, dce26f4, 9b3d5d2, 0e1e84a, b905d21, bad240d, 4c9f318, a6bdef4, 6d4170e, c82c874, d6f49b9, ff58b19, 0d6f9c4, 5c076cd, 3ec3dcd, ffdf2d6)
✅ login: voxpelli / name: Pelle Wessman (118fa4c)

- require.resolve() by Node.js follows a Node.js module resolution algo which includes checking if the resolved path actually exists on the file system.

coveralls · 2024-02-07T19:16:58Z

coverage: 94.257% (-0.1%) from 94.358%
when pulling 1a9f155 on khoaHyh:issue/4047
into 472a8be on mochajs:master.

JoshuaKGoldberg

Cool! 😎

Requesting changes on adding a bit more testing. But also let's talk about the direction a bit - I feel nervous adding in process.exit/throws deep within code. Thanks for sending!

test/integration/options/file.spec.js

lib/cli/collect-files.js

khoaHyh

@JoshuaKGoldberg tagging for re-review just in case this disappeared into the backlog abyss 😅

voxpelli · 2024-06-25T07:29:59Z

Thanks for stepping in and merging @JoshuaKGoldberg 🙏 🙂

feat: handle nonexistent files passed to --file

bd47d79

- added error handling when using the --file flag to do it the way --require does - added a test to assert that we throw the same type of error

khoaHyh marked this pull request as ready for review January 24, 2024 06:57

khoaHyh changed the title ~~ISSUE #4047: Add error handling for nonexistent file case with --file option~~ feat: Add error handling for nonexistent file case with --file option Jan 24, 2024

khoaHyh added 3 commits January 24, 2024 13:02

refactor: remove path.resolve()

4aad184

- require.resolve() by Node.js follows a Node.js module resolution algo which includes checking if the resolved path actually exists on the file system.

add comment to new code in collect-files.js

8983b84

fix: add back absolute path resolving

b6d6dc2

khoaHyh mentioned this pull request Feb 7, 2024

🚀 Feature: Better error for --file option with non-existent file #4047

Closed

khoaHyh added 3 commits February 6, 2024 22:59

refactor: log warning and remove call stack

9b3d5d2

revert changes to bin/mocha.js

645e0b0

improve test case

0e1e84a

khoaHyh added 2 commits February 10, 2024 23:19

Merge branch 'master' into issue/4047

9685b82

Merge branch 'master' into issue/4047

f8aedff

JoshuaKGoldberg requested changes Mar 4, 2024

View reviewed changes

test/integration/options/file.spec.js Show resolved Hide resolved

lib/cli/collect-files.js Outdated Show resolved Hide resolved

JoshuaKGoldberg added the status: waiting for author waiting on response from OP or other posters - more information needed label Mar 4, 2024

khoaHyh added 2 commits March 24, 2024 19:25

Merge branch 'master' into issue/4047

a6bdef4

throw error and have handler work with it

909834d

khoaHyh commented Mar 24, 2024

View reviewed changes

lib/cli/collect-files.js Show resolved Hide resolved

khoaHyh requested a review from JoshuaKGoldberg March 24, 2024 23:30

khoaHyh added 9 commits March 24, 2024 20:00

change collectFiles to return object

cf69df1

clean up

b905d21

exit mocha immediately on missing file

ea092be

new log message

6d4170e

add tests

bad240d

Merge branch 'master' into issue/4047

21e566d

Merge branch 'master' into issue/4047

dce26f4

Merge branch 'master' into issue/4047

4c9f318

Merge remote-tracking branch 'upstream/master' into issue/4047

1a9f155

khoaHyh commented May 29, 2024

View reviewed changes

JoshuaKGoldberg merged commit dbe229d into mochajs:main Jun 25, 2024

hoang3402 mentioned this pull request Jul 16, 2024

[Snyk] Upgrade mocha from 10.4.0 to 10.5.1 hoang3402/CodeWars#35

Closed

tylerezimmerman mentioned this pull request Jul 16, 2024

[Snyk] Upgrade mocha from 10.4.0 to 10.5.1 DelineaXPM/SS-ADO-BuildTask#71

Merged

tdbaine mentioned this pull request Jul 16, 2024

[Snyk] Upgrade mocha from 10.4.0 to 10.5.1 adamw1221/CS495-Lab-Inventory-Group-F#13

Open

M0ng00se7169 mentioned this pull request Jul 16, 2024

[Snyk] Upgrade mocha from 10.4.0 to 10.5.1 M0ng00se7169/Kickstart#88

Open

abdulrahman305 mentioned this pull request Jul 16, 2024

[Snyk] Upgrade mocha from 10.4.0 to 10.5.1 abdulrahman305/gauge#1

Merged

MaxMood96 mentioned this pull request Jul 17, 2024

[Snyk] Upgrade mocha from 10.2.0 to 10.5.1 MaxMood96/node-oracledb#99

Closed

abdulrahman305 mentioned this pull request Jul 17, 2024

[Snyk] Upgrade mocha from 10.4.0 to 10.5.2 abdulrahman305/gauge#2

Merged

Grizzelbee mentioned this pull request Jul 18, 2024

[Snyk] Upgrade mocha from 10.1.0 to 10.5.2 Grizzelbee/ioBroker.resol#152

Closed

SpinningRecords mentioned this pull request Jul 20, 2024

[Snyk] Upgrade mocha from 10.2.0 to 10.5.2 SpinningRecords/uBlock#5

Open

tylerezimmerman mentioned this pull request Jul 25, 2024

[Snyk] Upgrade mocha from 10.5.1 to 10.6.0 DelineaXPM/SS-ADO-BuildTask#72

Merged

saileshvyas mentioned this pull request Jul 27, 2024

[Snyk] Upgrade mocha from 10.2.0 to 10.6.0 saileshvyas/Microsoft-Defender-for-Cloud#5

Open

This was referenced Jul 28, 2024

[Snyk] Upgrade mocha from 10.2.0 to 10.6.0 hashim21223445/chai#3

Closed

[Snyk] Upgrade mocha from 10.4.0 to 10.6.0 hashim21223445/chai-as-promised#1

Merged

abdulrahman305 mentioned this pull request Jul 28, 2024

[Snyk] Upgrade mocha from 10.4.0 to 10.6.0 abdulrahman305/gauge#3

Merged

hashim21223445 mentioned this pull request Jul 29, 2024

[Snyk] Upgrade mocha from 10.3.0 to 10.6.0 hashim21223445/axios#2

Merged

hashim21223445 mentioned this pull request Aug 7, 2024

[Snyk] Upgrade mocha from 10.2.0 to 10.6.0 hashim21223445/broadcast-channel#7

Merged

abdulrahman305 mentioned this pull request Aug 10, 2024

[Snyk] Upgrade mocha from 10.4.0 to 10.7.0 abdulrahman305/gauge#4

Merged

This was referenced Aug 11, 2024

[Snyk] Upgrade mocha from 10.3.0 to 10.7.0 hashim21223445/axios#10

Merged

[Snyk] Upgrade mocha from 10.4.0 to 10.7.0 hashim21223445/chai-as-promised#5

Merged

abdulrahman305 mentioned this pull request Aug 13, 2024

[Snyk] Upgrade mocha from 10.2.0 to 10.7.0 abdulrahman305/tesseract.js#16

Closed

MaxMood96 mentioned this pull request Aug 25, 2024

[Snyk] Upgrade mocha from 10.2.0 to 10.7.0 MaxMood96/node-oracledb#102

Closed

SapiannykSerhii mentioned this pull request Sep 25, 2024

[Snyk] Upgrade mocha from 10.0.0 to 10.7.3 SapiannykSerhii/-NeWFestivaleWave-express_API_app#128

Open

MaxMood96 mentioned this pull request Oct 6, 2024

[Snyk] Upgrade mocha from 10.2.0 to 10.7.3 MaxMood96/node-oracledb#103

Closed

This was referenced Oct 23, 2024

[Snyk] Upgrade mocha from 9.2.2 to 10.7.3 nerdy-tech-com-gitub/preact#11

Open

[Snyk] Upgrade mocha from 9.2.2 to 10.7.3 nerdy-tech-com-gitub/node#8

Open

abdulrahman305 mentioned this pull request Oct 27, 2024

[Snyk] Upgrade mocha from 10.4.0 to 10.7.3 abdulrahman305/gauge#7

Closed

HaLaGu1L mentioned this pull request Nov 1, 2024

[Snyk] Upgrade mocha from 10.1.0 to 10.7.3 HaLaGu1L/wallet-core#7

Open

SkyeFull90 mentioned this pull request Nov 9, 2024

[Snyk] Upgrade mocha from 10.3.0 to 10.7.3 SkyeFull90/100devs-projects-skye#8

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix: Add error handling for nonexistent file case with --file option #5086

fix: Add error handling for nonexistent file case with --file option #5086

Uh oh!

khoaHyh commented Jan 24, 2024 •

edited by JoshuaKGoldberg

Loading

Uh oh!

linux-foundation-easycla bot commented Jan 24, 2024 •

edited

Loading

Uh oh!

coveralls commented Feb 7, 2024 •

edited

Loading

Uh oh!

JoshuaKGoldberg left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

khoaHyh left a comment

Uh oh!

voxpelli commented Jun 25, 2024

Uh oh!

Uh oh!

Uh oh!

fix: Add error handling for nonexistent file case with --file option #5086

fix: Add error handling for nonexistent file case with --file option #5086

Uh oh!

Conversation

khoaHyh commented Jan 24, 2024 • edited by JoshuaKGoldberg Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔎 Overview

Uh oh!

linux-foundation-easycla bot commented Jan 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coveralls commented Feb 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

khoaHyh left a comment

Choose a reason for hiding this comment

Uh oh!

voxpelli commented Jun 25, 2024

Uh oh!

Uh oh!

khoaHyh commented Jan 24, 2024 •

edited by JoshuaKGoldberg

Loading

linux-foundation-easycla bot commented Jan 24, 2024 •

edited

Loading

coveralls commented Feb 7, 2024 •

edited

Loading