Add custom capabilities setting to registry config #6077
Conversation
util/resolver/resolver_test.go
Outdated
| description: "http_mirror", | ||
| scheme: "http", | ||
| path: defaultPath, | ||
| capabilities: docker.HostCapabilityPull | docker.HostCapabilityResolve, |
There was a problem hiding this comment.
Why is this missing "push" if it should use default?
There was a problem hiding this comment.
The default capabilities for a registry mirror are ["pull", "resolve"], this PR doesn't change that:
buildkit/util/resolver/resolver.go
Line 180 in 0506df9
that http_mirror test just adds missing coverage for the existing (unchanged) behavior.
For more context on why this default is the way it is, see the capabilities field section in the containerd registry configuration documentation:
For example, pushing is a capability which should only be performed on an upstream
source, not a mirror.
Registry Type Pull Resolve Push Public Registry yes yes yes Private Registry yes yes yes Public Mirror yes no no Private Mirror yes yes no
This PR just enables 'push' to be added to a mirror for the narrow kind of use-case where it is actually useful to push to a mirror host, such as a local proxy (that will cache the content locally before forwarding it back upstream).
There was a problem hiding this comment.
But we don't have a separate config for mirror parameters. If this is happening because the test is always accessing through docker.io then add another testcase that tests accessing yourmirror.local directly and check that then it does have push cap.
There was a problem hiding this comment.
OK, I've reworked the test around to add an extra test case showing this behavior.
wjordan
force-pushed
the
registryconfig-capabilities
branch
from
92cdb05 to
aaaf978
Compare
Allows a registry mirror to be configured with the "push" capability which can be helpful in some proxy use-cases. Signed-off-by: Will Jordan <[email protected]>
wjordan
force-pushed
the
registryconfig-capabilities
branch
from
aaaf978 to
caadce7
Compare
Allows a registry mirror to be configured with the "push" capability which can be helpful in some proxy use-cases.