Skip to content

Conversation

mmaitre314
Copy link
Owner

  • Modules added: commands, numpy.testing._private.utils, ssl, timeit
  • Alphabetized modules

@mmaitre314 mmaitre314 requested a review from Copilot April 6, 2025 22:46
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • setup.cfg: Language not supported
Comments suppressed due to low confidence (2)

tests/test_scanner.py:157

  • There appears to be a duplicate or overwritten definition where class Malicious16 is first added (lines 116-130) and later replaced by class Malicious21. Consider removing the redundant Malicious16 to avoid confusion in the test payload definitions.
class Malicious21:

src/picklescan/scanner.py:144

  • [nitpick] The modules in the unsafe globals mapping are intended to be alphabetized per the PR description; however, the current order does not strictly follow alphabetical order. Consider reordering the entries to enhance readability and maintain consistency.
"timeit": "*",

@mmaitre314 mmaitre314 requested a review from Copilot April 6, 2025 22:49
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • setup.cfg: Language not supported
Comments suppressed due to low confidence (2)

tests/test_scanner.py:344

  • [nitpick] Consider directly referencing ssl_mod.get_server_certificate instead of using getattr for improved clarity.
return (getattr(ssl_mod, "get_server_certificate"), ((fqdn, 443),))

src/picklescan/scanner.py:91

  • [nitpick] Since the PR title indicates an alphabetized list of modules, please reorder the unsafe globals dictionary keys to maintain a consistent alphabetical order.
"numpy._core.multiarray": {

@mmaitre314 mmaitre314 merged commit 62e76cf into main Apr 6, 2025
3 checks passed
@mmaitre314 mmaitre314 deleted the users/mmaitre/add-imports branch August 26, 2025 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants