Skip to content

- Fix order of learners in generateLearningCurveData() #2768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 15, 2020
Merged

- Fix order of learners in generateLearningCurveData() #2768

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
740ddb3
Fix order of learners in generateLearningCurveData (Fixes #2767)
jakob-r Jun 15, 2020
4bcbddc
NEWS
jakob-r Jun 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
- Fix learner note for learner glmnet (the default of param `s` did not match the learner note) (#2747)
- Remove dep {hrbrthemes} used in `createSpatialResamplingPlots()`. The package caused issues on R-devel. In addition users should set custom themes by themselves.
- Explicitly return value in `getNestedTuneResultsOptPathDf()` (#2754)
- Fix wrong order of learners in `generateLearningCurveData()` (#2767)


# mlr 2.17.1.9000
Expand Down
16 changes: 6 additions & 10 deletions R/generateLearningCurve.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,26 +57,22 @@ generateLearningCurveData = function(learners, task, resampling = NULL,
}

# create downsampled versions for all learners
lrnds1 = lapply(learners, function(lrn) {
dsws = lapply(learners, function(lrn) {
lapply(seq_along(percs), function(p.id) {
perc = percs[p.id]
dsw = makeDownsampleWrapper(learner = lrn, dw.perc = perc, dw.stratify = stratify)
list(
lrn.id = lrn$id,
lrn = setLearnerId(dsw, stri_paste(lrn$id, ".", p.id)),
perc = perc
)
setLearnerId(dsw, stri_paste(lrn$id, ".", p.id))
})
})
lrnds2 = unlist(lrnds1, recursive = FALSE)
dsws = extractSubList(lrnds2, "lrn", simplify = FALSE)
dsws = unlist(dsws, recursive = FALSE)

bench.res = benchmark(dsws, task, resampling, measures, show.info = show.info)

perfs = getBMRAggrPerformances(bench.res, as.df = TRUE)

# get perc and learner col data
perc = extractSubList(lrnds2[as.factor(perfs$learner.id)], "perc")
learner = extractSubList(lrnds2[as.factor(perfs$learner.id)], "lrn.id")
perc = extractSubList(bench.res$learners, c("par.vals", "dw.perc")) # get downsample reate
learner = extractSubList(bench.res$learners, c("next.learner", "id")) #get ID of unwrapped learner
perfs = dropNamed(perfs, c("task.id", "learner.id"))

# set short measures names and resort cols
Expand Down