Skip to content

Conversation

mllg
Copy link
Member

@mllg mllg commented Apr 30, 2019

1st attempt to fix #2578

Copy link
Member

@pat-s pat-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also add an entry to NEWS.md?

DESCRIPTION Outdated
@@ -261,9 +261,6 @@ Suggests:
VignetteBuilder:
knitr
Remotes:
berndbischl/BBmisc,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this change on purpose or bc the Travis build failed back then?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why why install the devel version? If yes, we need to upload BBmisc before the next CRAN release. Otherwise it would be best to use the exact same version CRAN uses.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK there was but probably all problems have been fixed? I released v2.14.0 ofc without the Remotes Field and everything seems to be fine. So yes, I guess we can drop these requirements.

@pat-s
Copy link
Member

pat-s commented May 19, 2019

@mllg I added NEWS, please merge if you approve.

@pat-s pat-s changed the title Fix new data.table Bugfix: Aggregation of probabilities May 20, 2019
@mllg mllg merged commit b7c0279 into master May 20, 2019
@mllg
Copy link
Member Author

mllg commented May 20, 2019

Perfect, thanks!

@mllg mllg deleted the rbind_data_table branch May 20, 2019 07:17
vrodriguezf pushed a commit to vrodriguezf/mlr that referenced this pull request Jan 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in predictions due to recent change in data.table
2 participants