fixed ibrier measure #2425
Merged
fixed ibrier measure #2425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larskotthoff
requested changes
Aug 27, 2018
R/measures.R
Outdated
| @@ -1429,10 +1429,8 @@ ibrier = makeMeasure(id = "ibrier", minimize = TRUE, best = 0, worst = 1, | |||
|
|
|||
| probs = predictSurvProb(getLearnerModel(model, more.unwrap = TRUE), newdata = newdata, times = grid) | |||
| perror = pec(probs, f, data = newdata[, tn], times = grid, exact = FALSE, exactness = 99L, | |||
| maxtime = max.time, verbose = FALSE) | |||
| maxtime = max.time, verbose = FALSE, reference = F) | |||
There was a problem hiding this comment.
Please use FALSE instead of F.
R/measures.R
Outdated
|
|
||
| # FIXME: what is the difference between reference and matrix? | ||
| # FIXME: this might be the wrong number! |
There was a problem hiding this comment.
What about the FIXMEs you deleted? I guess that first one is irrelevant now, but what about the second?
There was a problem hiding this comment.
Sorry, I thought the second FIXME refers to a possible wrong number caused by the first FIXME. If that's not the case than I'm not sure what is meaning of the second FIXME. I'll put it back
|
Thanks, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference is a kaplan-meier curve model used to benchmark model performance against (since it uses no covariates). Matrix is the model performance measure. By adding "reference = F" in the pec call, I've removed the reference calculation thus speeding the code and fixing the problem of using reference instead of the fitted model error term.