feat: Support creating Lightcycler Sample Sheets for Absolute Quantification #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for creating Lightcycler Sample Sheets for Absolute Quantification, extending the existing relative quantification functionality. The implementation follows a similar pattern to the existing RelativeQuantificationSheet but with different column headers and sample properties specific to absolute quantification workflows.
- Introduces new
AbsoluteQuantificationSampleandAbsoluteQuantificationSheetclasses - Refactors string constants to
StringUtilfor reusability across both sheet types - Updates existing relative quantification code to use centralized string constants
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
src/LightcyclerSampleSheet/AbsoluteQuantificationSample.php |
New sample class for absolute quantification with properties like sample type and concentration |
src/LightcyclerSampleSheet/AbsoluteQuantificationSheet.php |
New sheet generator class following the same pattern as relative quantification |
src/StringUtil.php |
Added reusable constants for Windows line endings and tab separators |
src/LightcyclerSampleSheet/RelativeQuantificationSheet.php |
Refactored to use centralized string constants from StringUtil |
tests/LightcyclerSampleSheet/AbsoluteQuantificationSheetTest.php |
Comprehensive test coverage for the new absolute quantification functionality |
tests/LightcyclerSampleSheet/RelativeQuantificationSheetTest.php |
Minor refactoring to extract coordinate system variable |
CHANGELOG.md |
Documents the new feature addition |
delete non-existing AssertCountWithZeroToAssertEmptyRector add RemoveDataProviderParamKeysRector that breaks tests
… concentration and add formatting method
…solute-quantification' into lightcycler-sample-sheets-for-absolute-quantification
spawnia
reviewed
Aug 4, 2025
tests/LightcyclerSampleSheet/AbsoluteQuantificationSampleTest.php
Outdated
Show resolved
Hide resolved
…solute-quantification' into lightcycler-sample-sheets-for-absolute-quantification
spawnia
approved these changes
Aug 5, 2025
spawnia
deleted the
lightcycler-sample-sheets-for-absolute-quantification
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes