Dockerfile handles hathitrust validator dependency #139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* dotenv required in rsvp.rb * has to install jhove and the hathitrust feed repo
niquerio
force-pushed
the
get-validator-to-work
branch
from
9cb0236 to
02cc7fd
Compare
* docker image is cached * docker image for testing doesn't include ht validation stuff
niquerio
force-pushed
the
get-validator-to-work
branch
from
2728163 to
9a50992
Compare
antmoth
reviewed
Dec 3, 2025
|
|
||
| require "digest" | ||
| require "set" | ||
| require "set" # standard:disable all |
Collaborator
There was a problem hiding this comment.
is standard mad about file contents we don't control? (just curious)
Collaborator
Author
There was a problem hiding this comment.
My autoformatter wanted to delete that line and then the tests didn't work. I didn't care enough to dig deeper than this.
antmoth
approved these changes
Dec 3, 2025
Collaborator
antmoth
left a comment
antmoth
left a comment
There was a problem hiding this comment.
given that the tests are passing, looks good to me!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feedrepotestthat doesn't install all of thefeeddependencies.