-
Notifications
You must be signed in to change notification settings - Fork 89
[Refac] Refactor the pipeline. #428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Seven-Streams
merged 4 commits into
mlc-ai:main
from
Seven-Streams:main-dev/2025-09-11/refac_pipeline
Sep 25, 2025
Merged
[Refac] Refactor the pipeline. #428
Seven-Streams
merged 4 commits into
mlc-ai:main
from
Seven-Streams:main-dev/2025-09-11/refac_pipeline
Sep 25, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
226177e
to
a2bc8e6
Compare
a2bc8e6
to
d2b510a
Compare
Ubospica
reviewed
Sep 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
refac the file structure. add files. finish the basic refactor. finish the basic refac. add the optimized. fix the most tests. finish all the tests. Signed-off-by: Yuchuan <[email protected]> finish. Signed-off-by: Yuchuan <[email protected]> format. Signed-off-by: Yuchuan <[email protected]> fix cpp tests. normalize. fix. format. Signed-off-by: Yuchuan <[email protected]> refac. fix. refac testing. fix. fix test. tests. format. test, bump version. format. fix test. fix stag converter test. fix tests. Signed-off-by: Yuchuan <[email protected]> doc. functor.
Signed-off-by: Yuchuan <[email protected]>
efecca4
to
958f457
Compare
Signed-off-by: Yuchuan <[email protected]>
Ubospica
approved these changes
Sep 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebased version of #383.
This PR refactors the pipeline. The functors in
grammar_functor
are divided into three types:grammar_normalizer
: When a grammar is constructed, they should be called immediately.grammar_optimizer
: When a grammar is going to be compiled, they will be called.grammar_constructor
: They are used to construct a new grammar, like constructing the union of two grammars.