[Script] Add a tool to test the code coverage. #325
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At present, the FSM class can only build a FSM from a string. This PR
offers a basic RegexToFSM function.
These regex grammars are supported:
- Strings. For instance, `RegexToFSM("abc")` will build a FSM to accept
"abc".
- Character classes. For instance, `RegexToFSM("[a-z]")` will build a
FSM to accept characters from 'a' to 'z'.
- Repeatation(`*`, `+`, `?`, `{m}`, `{m, n}`).
- Union. (`|`).
Moreover, some basic optimization algorithms are implemented, which can
help to simplify the state machine:
- `ToDFA()`.(Powerset construction)
- `MinimizeDFA()`(Hopcraft Algorithm).
- `SimplifyTransition()`(Xgrammar node merging, type I)
- `SimplifyEpsilon()`(Xgrammar node merging, type II)
---------
Co-authored-by: Yixin Dong <[email protected]>
This reverts commit 11c2994.
Ubospica
reviewed
Jun 3, 2025
There was a problem hiding this comment.
Could you add a developer_guide.rst under docs/howto with a section about code coverage tool? Contents include
- How to use (cmake flags, script)
- Don't aim for a high code coverage rate, but good functionality coverage. Especially, complex functionality needs more tests which is not reflected in code cov rate.
|
got it |
Ubospica
approved these changes
Jun 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a script to test the code coverage.