[Fix] Add support for kDLCUDAHost in token bitmask device type check #242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Irfnfnkemed
commented
Mar 14, 2025
Irfnfnkemed
commented
- Modify the device type check to allow kDLCUDAHost in addition to kDLCPU.
- This change ensures that token bitmasks can be stored in pinned memory (kDLCUDAHost).
- Modify the device type check to allow kDLCUDAHost in addition to kDLCPU. - This change ensures that token bitmasks can be stored in pinned memory (kDLCUDAHost)
…check - Modify the device type check to allow kDLCUDAHost in addition to kDLCPU and kDLROCMHost. -This change ensures that logits and mask can be stored in pinned memory.
Seven-Streams
pushed a commit
to Seven-Streams/xgrammar
that referenced
this pull request
Mar 18, 2025
…lc-ai#242) - Modify the device type check to allow kDLCUDAHost in addition to kDLCPU. - This change ensures that token bitmasks can be stored in pinned memory (kDLCUDAHost).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.