Update CUDA sdpa #2468
Merged
Update CUDA sdpa #2468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awni
reviewed
Aug 6, 2025
Comment on lines
811
to
831
| inline fe::DataType_t dtype_to_cudnn_type(Dtype dtype) { | ||
| switch (dtype) { | ||
| case int8: | ||
| return fe::DataType_t::INT8; | ||
| case int32: | ||
| return fe::DataType_t::INT32; | ||
| case uint8: | ||
| return fe::DataType_t::UINT8; | ||
| case float16: | ||
| return fe::DataType_t::HALF; | ||
| case bfloat16: | ||
| return fe::DataType_t::BFLOAT16; | ||
| case float32: | ||
| return fe::DataType_t::FLOAT; | ||
| case float64: | ||
| return fe::DataType_t::DOUBLE; | ||
| default: | ||
| throw std::runtime_error(fmt::format( | ||
| "Unsupported dtype in SDPA: {}.", dtype_to_string(dtype))); | ||
| } | ||
| } |
There was a problem hiding this comment.
Maybe we can refactor that into a shared header cuddn.h that gets reused by conv.cpp?
awni
approved these changes
Aug 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Checklist
Put an
xin the boxes that apply.pre-commit run --all-filesto format my code / installed pre-commit prior to committing changes